Re: Patch for thinkpad-acpi.c

2013-05-28 Thread Bruce
Hi, Bjorn Thank your advice . I will modify my code, then try to submit again. Bruce.Ma May 29,2013 On 05/28/2013 06:28 PM, Bjørn Mork wrote: > Bruce writes: > >> +struct blacklist lenovo_blacklist[] = { >> + { >> +.model_s = "Lenovo LM490s", >> +.nummodel_s = "814YG01", >> + }, > >

Re: Patch for thinkpad-acpi.c

2013-05-28 Thread Bjørn Mork
Bruce writes: > +struct blacklist lenovo_blacklist[] = { > + { > +.model_s = "Lenovo LM490s", > +.nummodel_s = "814YG01", > + }, The driver already has a list of LED support per model in the static const struct tpacpi_quirk led_useful_qtable[] __initconst = {} array. Why do you

Patch for thinkpad-acpi.c

2013-05-28 Thread Bruce
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, all: We are testing Ubuntu 12.04 on some laptops , and find out there are some error messages in dmesg after run S3 or S4. Like: [10512.177806] ACPI Warning: For \_SB_.PCI0.LPCB.H_EC.LED_: Excess arguments - needs 1, found 2 (20110623/nspredef-32