Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 15:19 -0400, Kevin Winchester wrote: > > Yes, I've used quilt for working with mm patches in the past, but I'm > not too familiar with the mail features. For example, how do you get > the recipient list and Signed-off-by in the patch file? Do you just > edit it by hand?

Re: Possible locking issue in viotape.c

2007-12-08 Thread Kevin Winchester
Daniel Walker wrote: >> Yes, you are right, I hadn't finished looking at all of the up() calls >> when I came to my conclusion. I will try to convert a few that are not >> on your list, but I would like to know how you are generating your >> patches into those files with the diffstat and

Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 14:17 -0400, Kevin Winchester wrote: > Daniel Walker wrote: > > On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: > >> Daniel Walker wrote: > >>> I've posted all the ones I've done so far .. > >>> > >>> ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ > >>>

Re: Possible locking issue in viotape.c

2007-12-08 Thread Kevin Winchester
Daniel Walker wrote: > On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: >> Daniel Walker wrote: >>> I've posted all the ones I've done so far .. >>> >>> ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ >>> >>> Feel free to review or test them.. I've found it pretty easy to

Re: Possible locking issue in viotape.c

2007-12-08 Thread Kevin Winchester
Daniel Walker wrote: On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: Daniel Walker wrote: I've posted all the ones I've done so far .. ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ Feel free to review or test them.. I've found it pretty easy to simply grep for

Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 14:17 -0400, Kevin Winchester wrote: Daniel Walker wrote: On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: Daniel Walker wrote: I've posted all the ones I've done so far .. ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ Feel free to review

Re: Possible locking issue in viotape.c

2007-12-08 Thread Kevin Winchester
Daniel Walker wrote: Yes, you are right, I hadn't finished looking at all of the up() calls when I came to my conclusion. I will try to convert a few that are not on your list, but I would like to know how you are generating your patches into those files with the diffstat and recipient list.

Re: Possible locking issue in viotape.c

2007-12-08 Thread Daniel Walker
On Sat, 2007-12-08 at 15:19 -0400, Kevin Winchester wrote: Yes, I've used quilt for working with mm patches in the past, but I'm not too familiar with the mail features. For example, how do you get the recipient list and Signed-off-by in the patch file? Do you just edit it by hand? Or is

Re: Possible locking issue in viotape.c

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: > Daniel Walker wrote: > > > > I've posted all the ones I've done so far .. > > > > ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ > > > > Feel free to review or test them.. I've found it pretty easy to simply > > grep for

Possible locking issue in viotape.c

2007-12-06 Thread Kevin Winchester
Daniel Walker wrote: > > I've posted all the ones I've done so far .. > > ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ > > Feel free to review or test them.. I've found it pretty easy to simply > grep for certain class of semaphore usage, check if it's conforming to > the mutex

Possible locking issue in viotape.c

2007-12-06 Thread Kevin Winchester
Daniel Walker wrote: I've posted all the ones I've done so far .. ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ Feel free to review or test them.. I've found it pretty easy to simply grep for certain class of semaphore usage, check if it's conforming to the mutex

Re: Possible locking issue in viotape.c

2007-12-06 Thread Daniel Walker
On Thu, 2007-12-06 at 21:29 -0400, Kevin Winchester wrote: Daniel Walker wrote: I've posted all the ones I've done so far .. ftp://source.mvista.com/pub/dwalker/sem2mutex-2.6.24-rc4/ Feel free to review or test them.. I've found it pretty easy to simply grep for certain class of