Re: Potential Issue in Tracing Ring Buffer

2020-12-08 Thread J. Avila
Hello Steven, Thank you once again for all of your support. We saw that you also recently merged a change[1] which adds some validation for the timestamps in ring_buffer.c. Would you have any recommendations on how to add a more lightweight check for time going "backwards" in the timestamps? The i

Re: Potential Issue in Tracing Ring Buffer

2020-12-08 Thread Steven Rostedt
On Tue, 8 Dec 2020 11:37:13 -0800 "J. Avila" wrote: > Hello Steven, > > Thank you once again for all of your support. We saw that you also recently > merged a change[1] which adds some validation for the timestamps in > ring_buffer.c. Would you have any recommendations on how to add a more > lig

Re: Potential Issue in Tracing Ring Buffer

2020-11-30 Thread William Mcvicker
On Mon, Nov 30, 2020 at 09:48:46AM -0500, Steven Rostedt wrote: > On Thu, 26 Nov 2020 13:26:13 -0500 > Steven Rostedt wrote: > > > On Thu, 26 Nov 2020 06:52:45 +0100 > > Greg KH wrote: > > > > > On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > > > > Hello, > > > > > > > > In the f

Re: Potential Issue in Tracing Ring Buffer

2020-11-30 Thread Steven Rostedt
On Thu, 26 Nov 2020 13:26:13 -0500 Steven Rostedt wrote: > On Thu, 26 Nov 2020 06:52:45 +0100 > Greg KH wrote: > > > On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > > > Hello, > > > > > > In the ftrace logs we've collected internally, we have found that there > > > are > > > sit

Re: Potential Issue in Tracing Ring Buffer

2020-11-26 Thread Steven Rostedt
On Thu, 26 Nov 2020 06:52:45 +0100 Greg KH wrote: > On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > > Hello, > > > > In the ftrace logs we've collected internally, we have found that there are > > situations where time seems to go backwards; this breaks userspace tools > > which > >

Re: Potential Issue in Tracing Ring Buffer

2020-11-25 Thread Greg KH
On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > Hello, > > In the ftrace logs we've collected internally, we have found that there are > situations where time seems to go backwards; this breaks userspace tools which > expect time to always go forward in these logs. For example, in this

Re: Potential Issue in Tracing Ring Buffer

2020-11-24 Thread Steven Rostedt
On Tue, 24 Nov 2020 22:39:17 + "J. Avila" wrote: > Hello, > > In the ftrace logs we've collected internally, we have found that there are > situations where time seems to go backwards; this breaks userspace tools which > expect time to always go forward in these logs. For example, in this sn

Potential Issue in Tracing Ring Buffer

2020-11-24 Thread J. Avila
Hello, In the ftrace logs we've collected internally, we have found that there are situations where time seems to go backwards; this breaks userspace tools which expect time to always go forward in these logs. For example, in this snippet from a db845c running a 5.10-rc4 kernel[1] (thanks for gett