Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Dave Jones
On Mon, Apr 09, 2007 at 08:51:36PM -0700, Andrew Morton wrote: > On Mon, 9 Apr 2007 23:08:23 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > > This whole file is going away in .22, and we have a viable alternative > > in > > > .21 (acpi-cpufreq), so I'm not overly worried about fixing th

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Andrew Morton
On Mon, 9 Apr 2007 23:08:23 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > This whole file is going away in .22, and we have a viable alternative in > > .21 (acpi-cpufreq), so I'm not overly worried about fixing this up > > given it only shows up in debug kernels, especially at this stage in -

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Dave Jones
On Mon, Apr 09, 2007 at 11:05:00PM -0400, Dave Jones wrote: > This whole file is going away in .22, and we have a viable alternative in > .21 (acpi-cpufreq), so I'm not overly worried about fixing this up > given it only shows up in debug kernels, especially at this stage in -rc. > > (Yeah,

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Dave Jones
On Mon, Apr 09, 2007 at 07:41:42PM -0700, Andrew Morton wrote: > > > This means we'll call set_cpus_allowed() while in atomic state, but > > > set_cpus_allowed() does sleepy stuff. > > > > Puzzled. This diff shouldn't change anything about the context we're in > > when we call set_cpus_all

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Andrew Morton
On Mon, 9 Apr 2007 22:31:08 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Mon, Apr 09, 2007 at 05:26:51PM -0700, Andrew Morton wrote: > > On Thu, 5 Apr 2007 16:50:34 -0400 > > Dave Jones <[EMAIL PROTECTED]> wrote: > > > > > diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c >

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Dave Jones
On Mon, Apr 09, 2007 at 05:26:51PM -0700, Andrew Morton wrote: > On Thu, 5 Apr 2007 16:50:34 -0400 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c > > b/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c > > index f43b987..824d0a2

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-09 Thread Andrew Morton
On Thu, 5 Apr 2007 16:50:34 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > On Thu, Apr 05, 2007 at 02:33:03PM -0600, Jeff V. Merkey wrote: > > > > BUG: using smp_processor_id() in preemptible [0001] code: > > kondemand/0/2473 > > caller is centrino_target+0xfb/0x600 > > [<401e3646>] debu

Re: Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-05 Thread Dave Jones
On Thu, Apr 05, 2007 at 02:33:03PM -0600, Jeff V. Merkey wrote: > > BUG: using smp_processor_id() in preemptible [0001] code: > kondemand/0/2473 > caller is centrino_target+0xfb/0x600 > [<401e3646>] debug_smp_processor_id+0x9e/0xb0 > [<40112afb>] centrino_target+0xfb/0x600 > [<40112a00

Preemption Broken: centrino_target busted under SMP on 2.6.20.4

2007-04-05 Thread Jeff V. Merkey
BUG: using smp_processor_id() in preemptible [0001] code: kondemand/0/2473 caller is centrino_target+0xfb/0x600 [<401e3646>] debug_smp_processor_id+0x9e/0xb0 [<40112afb>] centrino_target+0xfb/0x600 [<40112a00>] centrino_target+0x0/0x600 [<40305bd9>] __cpufreq_driver_target+0x5c/0x6b [] do_d