Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-30 Thread Nayna Jain
On 10/25/2017 03:51 AM, Jarkko Sakkinen wrote: I noticed when making slides for KS that the naming for event log stuff that the naming is so broken that it is hard to understand the code. Here it really would make sense to have a patch set just to clean up the cruft. Random examples of more se

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-27 Thread Thiebaud Weksteen
On Thu, Oct 26, 2017 at 4:14 PM, Jarkko Sakkinen wrote: > On Wed, Oct 25, 2017 at 03:18:48PM +0200, Jarkko Sakkinen wrote: >> > Since this may conflict with the last patch set I sent, are you happy >> > for me to base this new set on tpmdd/master? >> >> What about this: you do an updated version o

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-26 Thread Jarkko Sakkinen
On Wed, Oct 25, 2017 at 03:18:48PM +0200, Jarkko Sakkinen wrote: > > Since this may conflict with the last patch set I sent, are you happy > > for me to base this new set on tpmdd/master? > > What about this: you do an updated version of your patch set that > includes these clean ups? > > PS. Sor

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-25 Thread Jarkko Sakkinen
On Wed, Oct 25, 2017 at 10:43:10AM +0200, Thiebaud Weksteen wrote: > On Wed, Oct 25, 2017 at 12:21 AM, Jarkko Sakkinen > wrote: > > I noticed when making slides for KS that the naming for event log stuff > > that the naming is so broken that it is hard to understand the code. > > Here it really wo

Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-25 Thread Thiebaud Weksteen
On Wed, Oct 25, 2017 at 12:21 AM, Jarkko Sakkinen wrote: > I noticed when making slides for KS that the naming for event log stuff > that the naming is so broken that it is hard to understand the code. > Here it really would make sense to have a patch set just to clean up the > cruft. Agreed and

Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

2017-10-24 Thread Jarkko Sakkinen
I noticed when making slides for KS that the naming for event log stuff that the naming is so broken that it is hard to understand the code. Here it really would make sense to have a patch set just to clean up the cruft. Random examples of more senseful naming: * tpm2_bios_measurements_start() sh