Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Alexandru Ardelean
On Fri, Nov 20, 2020 at 3:16 PM Lars-Peter Clausen wrote: > > On 11/20/20 12:54 PM, Alexandru Ardelean wrote: > > On Fri, Nov 20, 2020 at 12:47 PM Julia Lawall wrote: > >> > >> > >> On Thu, 19 Nov 2020, Joe Perches wrote: > >> > >>> On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: >

Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Lars-Peter Clausen
On 11/20/20 12:54 PM, Alexandru Ardelean wrote: On Fri, Nov 20, 2020 at 12:47 PM Julia Lawall wrote: On Thu, 19 Nov 2020, Joe Perches wrote: On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean wrote: Hey, So, I stumbled on a new

Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Alexandru Ardelean
On Fri, Nov 20, 2020 at 1:57 PM Julia Lawall wrote: > > > > On Fri, 20 Nov 2020, Alexandru Ardelean wrote: > > > On Fri, Nov 20, 2020 at 12:47 PM Julia Lawall wrote: > > > > > > > > > > > > On Thu, 19 Nov 2020, Joe Perches wrote: > > > > > > > On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko

Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Julia Lawall
On Fri, 20 Nov 2020, Alexandru Ardelean wrote: > On Fri, Nov 20, 2020 at 12:47 PM Julia Lawall wrote: > > > > > > > > On Thu, 19 Nov 2020, Joe Perches wrote: > > > > > On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: > > > > On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean > > > >

Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Alexandru Ardelean
On Fri, Nov 20, 2020 at 12:47 PM Julia Lawall wrote: > > > > On Thu, 19 Nov 2020, Joe Perches wrote: > > > On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: > > > On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean > > > wrote: > > > > > > > > Hey, > > > > > > > > So, I stumbled on a new

Re: [Cocci] Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-20 Thread Julia Lawall
On Thu, 19 Nov 2020, Joe Perches wrote: > On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: > > On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean > > wrote: > > > > > > Hey, > > > > > > So, I stumbled on a new check that could be added to checkpatch. > > > Since it's in Perl, I'm

Re: Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-19 Thread Joe Perches
On Thu, 2020-11-19 at 17:16 +0200, Andy Shevchenko wrote: > On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean > wrote: > > > > Hey, > > > > So, I stumbled on a new check that could be added to checkpatch. > > Since it's in Perl, I'm reluctant to try it. > > > > Seems many drivers got to a

Re: Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-19 Thread Andy Shevchenko
On Thu, Nov 19, 2020 at 4:09 PM Alexandru Ardelean wrote: > > Hey, > > So, I stumbled on a new check that could be added to checkpatch. > Since it's in Perl, I'm reluctant to try it. > > Seems many drivers got to a point where they now call (let's say) > spi_set_drvdata(), but never access that

Proposal for a new checkpatch check; matching _set_drvdata() & _get_drvdata()

2020-11-19 Thread Alexandru Ardelean
Hey, So, I stumbled on a new check that could be added to checkpatch. Since it's in Perl, I'm reluctant to try it. Seems many drivers got to a point where they now call (let's say) spi_set_drvdata(), but never access that information via spi_get_drvdata(). Reasons for this seem to be: 1. They