Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-26 Thread Mark Brown
On Mon, Nov 26, 2018 at 10:11:48AM -0800, Doug Anderson wrote: > just takes the load you pass it and sends it on. It looks like you > can still force the mode but it looks like it's using a custom > attribute for that (qcom,force-mode). I wonder if that should be > changed to use 'regulator-init

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-26 Thread Mark Brown
On Mon, Nov 26, 2018 at 09:43:42AM -0800, Doug Anderson wrote: > NOTE: another option would be to change the regulator driver to just > force this rail to a high power mode and never let it change. That's > what we're doing on a SDM845-based board. When the regulator is off > the mode doesn't ma

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-26 Thread Doug Anderson
Hi, On Mon, Nov 26, 2018 at 9:59 AM Mark Brown wrote: > > On Mon, Nov 26, 2018 at 09:43:42AM -0800, Doug Anderson wrote: > > > NOTE: another option would be to change the regulator driver to just > > force this rail to a high power mode and never let it change. That's > > what we're doing on a S

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-26 Thread Doug Anderson
Hi, On Sun, Nov 25, 2018 at 3:24 PM Brian Masney wrote: > > > I guess this is a workaround for drivers that don't set the load > > properly themselves? > > I'm honestly not sure when the load should be set in the driver or in > device tree. None of the drivers in drivers/mmc/ call > regulator_set

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-26 Thread Mark Brown
On Sun, Nov 25, 2018 at 06:24:50PM -0500, Brian Masney wrote: > On Sun, Nov 25, 2018 at 09:20:02AM -0800, Doug Anderson wrote: > > I guess this is a workaround for drivers that don't set the load > > properly themselves? > I'm honestly not sure when the load should be set in the driver or in > de

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Brian Masney
Hi Doug, On Sun, Nov 25, 2018 at 09:20:02AM -0800, Doug Anderson wrote: > On Sun, Nov 25, 2018 at 1:37 AM Brian Masney wrote: > > I bisected the issue to the following commit: > > > > 5451781dadf8 ("regulator: core: Only count load for enabled consumers") > > > > We have to increase the load for

Re: Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Doug Anderson
Hi, On Sun, Nov 25, 2018 at 1:37 AM Brian Masney wrote: > I bisected the issue to the following commit: > > 5451781dadf8 ("regulator: core: Only count load for enabled consumers") > > We have to increase the load for the sdhci in device tree in order for > the phone to boot properly. This change

Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Brian Masney
Hi all, I see errors like the following in linux next-20181123 when trying to boot a mainline kernel on a LG Nexus 5 phone: [ 14.495056] mmc1: Card stuck in wrong state! mmcblk1 card_busy_detect status: 0xe00 [ 14.495185] mmc1: cache flush error -110 [ 14.601547] mmc1: Reset 0x1 never comp