Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

2020-05-07 Thread Masahiro Yamada
On Thu, May 7, 2020 at 8:43 PM Maninder Singh wrote: > > Hi Masahiro, > > Thanks for review. > We will integrate your review comements and send v2. > > >> > > >> so making regex $re for ARM similar to aarch64 > >> > >> Signed-off-by: Vaneet Narang > >> Signed-off-by: Maninder Singh > > > > > >Th

RE:[PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

2020-05-07 Thread Maninder Singh
Hi Masahiro, Thanks for review. We will integrate your review comements and send v2. >> >> so making regex $re for ARM similar to aarch64 >> >> Signed-off-by: Vaneet Narang >> Signed-off-by: Maninder Singh > > >This looks good to me, and it is a bug fix. > >Just a question about the SOB. >

Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex

2020-05-07 Thread Masahiro Yamada
On Thu, Apr 30, 2020 at 9:50 PM Maninder Singh wrote: > > if objdump has below entries; > c01ed608 : > c01ed614: e24ddff7sub sp, sp, #120; 0x78 > > c01f0d50 : > c01f0d50: e24dd094sub sp, sp, #140; 0x8c > > scripts fails to read stack usage. > so making r