RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-03 Thread Ju, Seokmann
On Wednesday, February 02, 2005 5:43 PM, James wrote: > > + .sdev_attrs = megaraid_device_attrs, > > + .shost_attrs= megaraid_class_device_attrs, > > These are, perhaps, slightly confusing names. The terms device and > class_device have well defined

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-03 Thread Ju, Seokmann
On Wednesday, February 02, 2005 5:43 PM, James wrote: + .sdev_attrs = megaraid_device_attrs, + .shost_attrs= megaraid_class_device_attrs, These are, perhaps, slightly confusing names. The terms device and class_device have well defined meanings

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-02 Thread James Bottomley
On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote: > + .sdev_attrs = megaraid_device_attrs, > + .shost_attrs= megaraid_class_device_attrs, These are, perhaps, slightly confusing names. The terms device and class_device have well defined

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-02 Thread Ju, Seokmann
On Tuesday, February 01, 2005 1:15 PM, Matt Domsch wrote: > This patch is mangled. Long lines are wrapped, and appears to be in > ISO-8859-1, such that spaces (ascii 0x20) appear as hex 0xa0. This > makes it difficult to review, and impossible to apply. > > +// definitions for the device

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-02 Thread Ju, Seokmann
On Tuesday, February 01, 2005 1:15 PM, Matt Domsch wrote: This patch is mangled. Long lines are wrapped, and appears to be in ISO-8859-1, such that spaces (ascii 0x20) appear as hex 0xa0. This makes it difficult to review, and impossible to apply. +// definitions for the device attributes

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-02 Thread James Bottomley
On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote: + .sdev_attrs = megaraid_device_attrs, + .shost_attrs= megaraid_class_device_attrs, These are, perhaps, slightly confusing names. The terms device and class_device have well defined meanings