RE: [Bug fix] octeon-i2c driver updates

2017-12-05 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
com Cc: w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates On 12/04/2017 10:44 PM, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Hi Jan, > > Thanks for your comments, I get your point for the second point (retry

RE: [Bug fix] octeon-i2c driver updates

2017-12-05 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
(NSB - CN/Hangzhou) > Cc: david.da...@cavium.com; w...@the-dreams.de; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [Bug fix] octeon-i2c driver updates > > Hi Sean, > > as you try to solve two different issues I suggest that you create one > pa

Re: [Bug fix] octeon-i2c driver updates

2017-12-05 Thread David Daney
o:jan.glau...@caviumnetworks.com] Sent: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) <sean.c.zh...@nokia-sbell.com> Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as

Re: [Bug fix] octeon-i2c driver updates

2017-12-05 Thread David Daney
o:jan.glau...@caviumnetworks.com] Sent: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as you try to solve two different issues

RE: [Bug fix] octeon-i2c driver updates

2017-12-04 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
nt: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) <sean.c.zh...@nokia-sbell.com> Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as you try to solve two di

RE: [Bug fix] octeon-i2c driver updates

2017-12-04 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
nt: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as you try to solve two different issues I suggest that you

Re: [Bug fix] octeon-i2c driver updates

2017-12-01 Thread Jan Glauber
ernel.org; > linux-kernel@vger.kernel.org > Subject: RE: [Bug fix] octeon-i2c driver updates > > Hi Jan, > > There are two points in this patch. > > Point 1. As you see, replaced octeon_i2c_init_lowlevel() by recover bus > status if TWSI controller is not IDLE. > Pl

Re: [Bug fix] octeon-i2c driver updates

2017-12-01 Thread Jan Glauber
tion. > > BR, > Sean Zhang > > -Original Message- > From: Jan Glauber [mailto:jan.glau...@caviumnetworks.com] > Sent: Friday, November 24, 2017 9:10 PM > To: Zhang, Sean C. (NSB - CN/Hangzhou) > Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@v

RE: [Bug fix] octeon-i2c driver updates

2017-11-29 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
el.org; linux-kernel@vger.kernel.org Subject: RE: [Bug fix] octeon-i2c driver updates Hi Jan, There are two points in this patch. Point 1. As you see, replaced octeon_i2c_init_lowlevel() by recover bus status if TWSI controller is not IDLE. Please take a scenario like this: when system soft reset w

RE: [Bug fix] octeon-i2c driver updates

2017-11-29 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
Subject: RE: [Bug fix] octeon-i2c driver updates Hi Jan, There are two points in this patch. Point 1. As you see, replaced octeon_i2c_init_lowlevel() by recover bus status if TWSI controller is not IDLE. Please take a scenario like this: when system soft reset without I2C slave reset, maybe make

RE: [Bug fix] octeon-i2c driver updates

2017-11-27 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe

RE: [Bug fix] octeon-i2c driver updates

2017-11-27 Thread Zhang, Sean C. (NSB - CN/Hangzhou)
-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe can be improved. Hi Se

Re: [Bug fix] octeon-i2c driver updates

2017-11-24 Thread Jan Glauber
On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe can be improved. Hi Sean, form the description below this looks like you're fixing a bug. Can you elaborate on when the I2C bus

Re: [Bug fix] octeon-i2c driver updates

2017-11-24 Thread Jan Glauber
On Thu, Nov 23, 2017 at 11:42:36AM +, Zhang, Sean C. (NSB - CN/Hangzhou) wrote: > Dear Maintainer, > > For octeon TWSI controller, I found below two cases, maybe can be improved. Hi Sean, form the description below this looks like you're fixing a bug. Can you elaborate on when the I2C bus