Re: [NEW DRIVER V2 5/7] DA9058 GPIO driver

2012-08-13 Thread Linus Walleij
Hi Anthony, sorry for delayed reply... On Sun, Aug 5, 2012 at 10:43 PM, Anthony Olech wrote: > This is the GPIO component driver of the Dialog DA9058 PMIC. > This driver is just one component of the whole DA9058 PMIC driver. > It depends on the core DA9058 MFD driver. OK > +config GPIO_DA9058

Re: [NEW DRIVER V2 5/7] DA9058 GPIO driver

2012-08-13 Thread Mark Brown
On Mon, Aug 13, 2012 at 03:09:31PM +0200, Linus Walleij wrote: > On Sun, Aug 5, 2012 at 10:43 PM, Anthony Olech > > +#include > If you're using regmap you better select it in Kconfig > too, but it appears you don't. You should be using regmap in the > main MFD driver in this case (I haven't look

RE: [NEW DRIVER V2 5/7] DA9058 GPIO driver

2012-08-15 Thread Opensource [Anthony Olech]
> -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: 13 August 2012 14:10 > To: Opensource [Anthony Olech] > Cc: Grant Likely; Linus Walleij; Mark Brown; LKML; David Dajun Chen; Samuel > Ortiz; Lee Jones > Subject: Re: [NEW DRIVER V2 5/

Re: [NEW DRIVER V2 5/7] DA9058 GPIO driver

2012-08-15 Thread Linus Walleij
On Wed, Aug 15, 2012 at 12:08 PM, Opensource [Anthony Olech] wrote: > [Me] >> > + if (offset > 1) >> > + return -EINVAL; >> So there are two GPIO pins, 0 and 1? That seems odd, but OK. > > That is a feature of the hardware. I believe that calling them "0" and > "1" is the corr