Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-18 Thread Mark Brown
On Mon, Sep 17, 2012 at 12:07:11PM +, Opensource [Anthony Olech] wrote: > > > Can you suggest a future proofed way of using the new regulator API > > > that would solve my problem? > > As I said you should set the voltage as part of the set voltage operation. > So I will have to write my

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-18 Thread Mark Brown
On Mon, Sep 17, 2012 at 12:07:11PM +, Opensource [Anthony Olech] wrote: Can you suggest a future proofed way of using the new regulator API that would solve my problem? As I said you should set the voltage as part of the set voltage operation. So I will have to write my own

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: 17 September 2012 12:33 > To: Opensource [Anthony Olech] > Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David > Dajun Chen > Subject: Re: [NEW DRIVER V3

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 11:23:54AM +, Opensource [Anthony Olech] wrote: > Can you suggest a future proofed way of using the new regulator API that > would solve my problem? As I said you should set the voltage as part of the set voltage operation. -- To unsubscribe from this list: send the

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: 17 September 2012 12:16 > To: Opensource [Anthony Olech] > Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David > Dajun Chen > Subject: Re: [NEW DRIVER V3

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 10:49:22AM +, Opensource [Anthony Olech] wrote: > I thought that the set_voltage_sel = regulator_set_voltage_sel_regmap > callback first > set the target voltage, and that the set_voltage_time_sel = > da9058_buck_ramp_voltage > callback was called afterwards? > was

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: 17 September 2012 11:40 > To: Opensource [Anthony Olech] > Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David > Dajun Chen > Subject: Re: [NEW DRIVER V3

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 10:29:43AM +, Opensource [Anthony Olech] wrote: > > Why is this function writing to the hardware, especially writing the same > > value > > every time? > the ramp_register is DA9058_SUPPLY_REG and it is marked as volitile. > Writing to the ramp enable bit starts the

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: 27 August 2012 17:51 > To: Opensource [Anthony Olech] > Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David > Dajun Chen > Subject: Re: [NEW DRIVER V3

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: 27 August 2012 17:51 To: Opensource [Anthony Olech] Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David Dajun Chen Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 10:29:43AM +, Opensource [Anthony Olech] wrote: Why is this function writing to the hardware, especially writing the same value every time? the ramp_register is DA9058_SUPPLY_REG and it is marked as volitile. Writing to the ramp enable bit starts the voltage

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: 17 September 2012 11:40 To: Opensource [Anthony Olech] Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David Dajun Chen Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 10:49:22AM +, Opensource [Anthony Olech] wrote: I thought that the set_voltage_sel = regulator_set_voltage_sel_regmap callback first set the target voltage, and that the set_voltage_time_sel = da9058_buck_ramp_voltage callback was called afterwards? was I

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: 17 September 2012 12:16 To: Opensource [Anthony Olech] Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David Dajun Chen Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Mark Brown
On Mon, Sep 17, 2012 at 11:23:54AM +, Opensource [Anthony Olech] wrote: Can you suggest a future proofed way of using the new regulator API that would solve my problem? As I said you should set the voltage as part of the set voltage operation. -- To unsubscribe from this list: send the

RE: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-09-17 Thread Opensource [Anthony Olech]
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: 17 September 2012 12:33 To: Opensource [Anthony Olech] Cc: Liam Girdwood; Guenter Roeck; Jean Delvare; Randy Dunlap; LKML; David Dajun Chen Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-08-27 Thread Mark Brown
On Wed, Aug 15, 2012 at 04:05:25PM +0100, Anthony Olech wrote: > +static int da9058_buck_ramp_voltage(struct regulator_dev *rdev, > + unsigned int old_selector, > + unsigned int new_selector) > +{ > + ret =

Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver

2012-08-27 Thread Mark Brown
On Wed, Aug 15, 2012 at 04:05:25PM +0100, Anthony Olech wrote: +static int da9058_buck_ramp_voltage(struct regulator_dev *rdev, + unsigned int old_selector, + unsigned int new_selector) +{ + ret =