Re: [PATCH] [v2] nvme-pci: check req to prevent crash in nvme_handle_cqe()

2020-09-01 Thread Keith Busch
On Mon, Aug 31, 2020 at 06:55:53PM +0800, Xianting Tian wrote: > As blk_mq_tag_to_rq() may return null, so it should be check whether it is > null before using it to prevent a crash. It may return NULL if the command id exceeds the number of tags. We already have a check for a valid command id

RE: [PATCH] [v2] nvme-pci: check req to prevent crash in nvme_handle_cqe()

2020-09-01 Thread Tianxianting
Hi, Could I get the feedback for the patch, whether it can be applied or need some improvement? It really can prevent a crash we met. Thanks:) -Original Message- From: tianxianting (RD) Sent: Monday, August 31, 2020 6:56 PM To: kbu...@kernel.org; ax...@fb.com; h...@lst.de;