RE: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2017-01-04 Thread David Laight
From: Harisangam, Sharvari (S.) > Sent: 28 December 2016 11:07 > Corrected the condition to check if ssi is configured for AC97 > mode. Other modes like dsp_a also satisfy the ANDing condition. Under the assumption that the constants have 1 bit set nothing is wrong. David ... > -

RE: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2017-01-04 Thread David Laight
From: Harisangam, Sharvari (S.) > Sent: 28 December 2016 11:07 > Corrected the condition to check if ssi is configured for AC97 > mode. Other modes like dsp_a also satisfy the ANDing condition. Under the assumption that the constants have 1 bit set nothing is wrong. David ... > -

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Harisangam, Sharvari (S.)
On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote: > On Dez 28 2016, "Harisangam, Sharvari (S.)" > wrote: > > > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > > + SND_SOC_DAIFMT_AC97; > > This is never true. > > Andreas.

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Harisangam, Sharvari (S.)
On Wed, Dec 28, 2016 at 03:50:57PM +0100, Andreas Schwab wrote: > On Dez 28 2016, "Harisangam, Sharvari (S.)" > wrote: > > > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > > + SND_SOC_DAIFMT_AC97; > > This is never true. > > Andreas. > > -- > Andreas Schwab,

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, Timur Tabi wrote: > Andreas Schwab wrote: >>> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == >>> > + SND_SOC_DAIFMT_AC97; >> This is never true. > > I think the right parenthesis should be at the end of the expression. That would still test

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, Timur Tabi wrote: > Andreas Schwab wrote: >>> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == >>> > + SND_SOC_DAIFMT_AC97; >> This is never true. > > I think the right parenthesis should be at the end of the expression. That would still test the wrong

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Timur Tabi
Andreas Schwab wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. I think the right parenthesis should be at the end of the expression.

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Timur Tabi
Andreas Schwab wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. I think the right parenthesis should be at the end of the expression.

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7

Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, "Harisangam, Sharvari (S.)" wrote: > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) == > + SND_SOC_DAIFMT_AC97; This is never true. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276