Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMSUNG > will be selected automatically. Of course, it can be de-selected in kernel > menuconfig. Note that, I think, using 'bool ' and 'depends on ' > is more clear

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > > Thierry Reding wrote: > > > > > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: > > [...] > He (she?) sent two patches: > He :-) > https://lkml.org/lkml/2012/8/2/108 >

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: > Thierry Reding wrote: > > > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: > > [...] > > > > Yeah, your pointing out is correct, but in this case, it should be > > 'bool' > > > not 'tristate' because the PWM driver

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] > > Yeah, your pointing out is correct, but in this case, it should be > 'bool' > > not 'tristate' because the PWM driver cannot support module now. > > Is there any reason why that is so? I mean,

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: > Thierry Reding wrote: > > > > On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: > > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- > > samsung/Kconfig > > > index 7aca31c..dcdfb77 100644 > > > ---

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: > > On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- > samsung/Kconfig > > index 7aca31c..dcdfb77 100644 > > --- a/arch/arm/plat-samsung/Kconfig > > +++ b/arch/arm/plat-samsung/Kconfig > > @@ -403,7

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index 7aca31c..dcdfb77 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI > >

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -403,7 +403,7 @@ config S5P_DEV_USB_EHCI config

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- samsung/Kconfig index 7aca31c..dcdfb77 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -403,7 +403,7 @@

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: Thierry Reding wrote: On Wed, Aug 08, 2012 at 09:54:13AM +0900, Kukjin Kim wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- samsung/Kconfig index 7aca31c..dcdfb77 100644 ---

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] Yeah, your pointing out is correct, but in this case, it should be 'bool' not 'tristate' because the PWM driver cannot support module now. Is there any reason why that is so? I mean, current

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: Thierry Reding wrote: On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] Yeah, your pointing out is correct, but in this case, it should be 'bool' not 'tristate' because the PWM driver cannot support

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Kukjin Kim
Thierry Reding wrote: On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: Thierry Reding wrote: On Wed, Aug 08, 2012 at 03:30:32PM +0900, Kukjin Kim wrote: [...] He (she?) sent two patches: He :-) https://lkml.org/lkml/2012/8/2/108

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-08 Thread Thierry Reding
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote: So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMSUNG will be selected automatically. Of course, it can be de-selected in kernel menuconfig. Note that, I think, using 'bool expr' and 'depends on expr' is more

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Tushar Behera
On 08/08/2012 07:02 AM, Kukjin Kim wrote: > Kukjin Kim wrote: >> > > [...] > >> >> From: Tushar Behera >> Subject: [PATCH] ARM: SAMSUNG: Fix compilation error with >> s3c2410_defconfig >> >> Commit 2663e766c56a ("ARM Samsung: Move s3c pwm driver to pwm framework") > > Oops, this should be

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Kukjin Kim wrote: > [...] > > From: Tushar Behera > Subject: [PATCH] ARM: SAMSUNG: Fix compilation error with > s3c2410_defconfig > > Commit 2663e766c56a ("ARM Samsung: Move s3c pwm driver to pwm framework") Oops, this should be "215c29d3d0e9"... Thanks. Best regards, Kgene. -- Kukjin Kim

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Tushar Behera wrote: > > On 08/07/2012 04:03 PM, Kukjin Kim wrote: > > Tushar Behera wrote: > >> > >> Commit 2663e766c56a "ARM Samsung: Move s3c pwm driver to pwm framework" > >> moved Samsung PWM driver to drivers/pwm and the config option to select > >> this driver has changed. > >> > >> This

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Tushar Behera
On 08/07/2012 04:03 PM, Kukjin Kim wrote: > Tushar Behera wrote: >> >> Commit 2663e766c56a "ARM Samsung: Move s3c pwm driver to pwm framework" >> moved Samsung PWM driver to drivers/pwm and the config option to select >> this driver has changed. >> >> This patch fixes following build-error with

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Tushar Behera wrote: > > Commit 2663e766c56a "ARM Samsung: Move s3c pwm driver to pwm framework" > moved Samsung PWM driver to drivers/pwm and the config option to select > this driver has changed. > > This patch fixes following build-error with s3c2410_defconfig. >

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Tushar Behera wrote: Commit 2663e766c56a ARM Samsung: Move s3c pwm driver to pwm framework moved Samsung PWM driver to drivers/pwm and the config option to select this driver has changed. This patch fixes following build-error with s3c2410_defconfig.

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Tushar Behera
On 08/07/2012 04:03 PM, Kukjin Kim wrote: Tushar Behera wrote: Commit 2663e766c56a ARM Samsung: Move s3c pwm driver to pwm framework moved Samsung PWM driver to drivers/pwm and the config option to select this driver has changed. This patch fixes following build-error with

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Tushar Behera wrote: On 08/07/2012 04:03 PM, Kukjin Kim wrote: Tushar Behera wrote: Commit 2663e766c56a ARM Samsung: Move s3c pwm driver to pwm framework moved Samsung PWM driver to drivers/pwm and the config option to select this driver has changed. This patch fixes following

RE: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Kukjin Kim
Kukjin Kim wrote: [...] From: Tushar Behera tushar.beh...@linaro.org Subject: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Commit 2663e766c56a (ARM Samsung: Move s3c pwm driver to pwm framework) Oops, this should be 215c29d3d0e9... Thanks. Best regards, Kgene.

Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig

2012-08-07 Thread Tushar Behera
On 08/08/2012 07:02 AM, Kukjin Kim wrote: Kukjin Kim wrote: [...] From: Tushar Behera tushar.beh...@linaro.org Subject: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Commit 2663e766c56a (ARM Samsung: Move s3c pwm driver to pwm framework) Oops, this should be