Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-22 Thread Andrew Lunn
> There is a way of doing this to preserve backwards compatibility I think. > Maybe deprecating the previous DTS phy-mode and replacing it with a new one, > phy-mode-v2 instead? Hi Steve It needs to be a vendor specific property, atheros,phy-mode, for example. Andrew

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-22 Thread Steve Twiss
Here are my thoughts. On 22 March 2019 10:21, Michal Vokáč wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > On 22. 03. 19 3:24, Fabio Estevam wrote: > > On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo wrote: > > > >>

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-22 Thread Michal Vokáč
On 22. 03. 19 3:24, Fabio Estevam wrote: On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo wrote: Unfortunately, just by looking at the dts files we do not know if a board uses an AR803x PHY or not, so I am afraid we can not do an automatic conversion. At least for those we already know? Yes, I

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Fabio Estevam
On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo wrote: > > Unfortunately, just by looking at the dts files we do not know if a > > board uses an AR803x PHY or not, so I am afraid we can not do an > > automatic conversion. > > At least for those we already know? Yes, I can help preparing a patch that

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 11:00:18PM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Thu, Mar 21, 2019 at 10:12 PM Shawn Guo wrote: > > > > So yes, we currently have lots of broken dtb's in mainline and I am > > > wondering what is the proper fix here. > > > > So can we have a single patch fixing

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Fabio Estevam
Hi Shawn, On Thu, Mar 21, 2019 at 10:12 PM Shawn Guo wrote: > > So yes, we currently have lots of broken dtb's in mainline and I am > > wondering what is the proper fix here. > > So can we have a single patch fixing all broken i.MX DTBs? Unfortunately, just by looking at the dts files we do

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Shawn Guo
On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote: > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does anyone

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Lucas Stach
Am Donnerstag, den 21.03.2019, 08:17 -0300 schrieb Fabio Estevam: > Hi Abel, > > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Andrew Lunn
> I bisected to the original breakage (for the NFS rootfs) back to this commit: > commit 13d0ab6750b20957ac1466da4e44dc0af746ff28 I don't think that is the correct patch. Yes, it broke here, but that was a different problem. I think the real commit is: 6d4cd041f0af ("net: phy: at803x: disable

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Andrew Lunn
On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote: > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does anyone

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Steve Twiss
Hi Fabio, On 21 March 2019 11:17, Fabio Estevam, > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed an

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Fabio Estevam
Hi Abel, On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > It seems we have other boards that need to be fixed and we can not > > have an old dtb with functional Ethernet with a new kernel. > > > > Does anyone know if this issue is AR8031 specific? > > I can confirm the same fix is works on

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Abel Vesa
On 19-03-20 14:04:42, Fabio Estevam wrote: > Hi Steve, > > [Adding Andrew] > > On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss > wrote: > > > > Hi Fabio, > > > > On 20 March 2019 12:17, Fabio Estevam wrote: > > > Subject: Re: [PATCH] ARM: dts: imx6

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Fabio Estevam
Hi Steve, [Adding Andrew] On Wed, Mar 20, 2019 at 1:03 PM Steve Twiss wrote: > > Hi Fabio, > > On 20 March 2019 12:17, Fabio Estevam wrote: > > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > > rgmii-id > > > > Hi Steve, > >

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Steve Twiss
Hi Fabio, On 20 March 2019 12:17, Fabio Estevam wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Steve, > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss > wrote: > > > > The PHY used on the Freescale i.

Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Fabio Estevam
Hi Steve, On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss wrote: > > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were This patch declares it as 'rgmii-id', which contradicts the commit log. > previously