RE: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-06 Thread Lu, Brent
> > Looks there is race between the previous stream stop and the current > stream start here. Can you help try changing the > sst_byt_stream_start/stop() from 'nowait' mode to 'wait' mode, and see if > the issue can be reproduced with it? Hi Keyon, Kernel panic if the mode is changed. The

Re: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-05 Thread Keyon Jie
On 4/22/20 12:16 AM, Lu, Brent wrote: Regs width difference between BDW and BYT comes from specification. BDW has IPC registers which are 32 wide. This fact ain't exactly the reason to modify sst_shim32_read64. I'm sharing Amadeo's point of view. Your change should slow down execution a

RE: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-05 Thread Lu, Brent
> > Hi, > > That's why I would suggest trying with readq, it should also generate one > instruction read x86_64 platforms, I looked a bit more and there is fallback > to > generate two 32 bit reads on 32bit platforms, so my previous concern about > having to write separate handling for those

Re: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-04 Thread Amadeusz Sławiński
On 4/30/2020 5:38 PM, Lu, Brent wrote: Hi, yes that seems bit weird. It is bit better as it does not modify common code, but still... Maybe going back to your original idea of replacing memcpy, try replacing it with readq? It should generate one instruction read (although it is only for

RE: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-04-30 Thread Lu, Brent
> > Hi, > yes that seems bit weird. It is bit better as it does not modify common code, > but still... Maybe going back to your original idea of replacing memcpy, try > replacing it with readq? It should generate one instruction read (although it > is > only for x64_64, for 32 bit kernel we

Re: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-04-29 Thread Amadeusz Sławiński
On 4/28/2020 7:29 PM, Lu, Brent wrote: I've looked at the code and byt_is_dsp_busy seems suspicious to me. Can you check if following change fixes problem for you:(...) We seem to treat SST_IPCX as 32 bit register instead of 64 one, which may explain wrong behaviour. (Specification says it

RE: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-04-28 Thread Lu, Brent
> > I've looked at the code and byt_is_dsp_busy seems suspicious to me. > Can you check if following change fixes problem for you: > > diff --git a/sound/soc/intel/baytrail/sst-baytrail-ipc.c > b/sound/soc/intel/baytrail/sst-baytrail-ipc.c > index 74274bd38f7a..34746fd871b0 100644 > ---