RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Lu, Brent
> > Now I noticed that the legacy driver already addressed it recently via commit > 6d011d5057ff > ALSA: hda: Clear RIRB status before reading WP > > We should have checked SOF at the same time, too... > > > thanks, > > Takashi Hi Takashi-san, Yes you are correct. I tested Chrome v5.4 on

RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Lu, Brent
> > IIRC we added this loop before merging all interrupt handling in one thread, > somehow the MSI mode never worked reliably without this change, so > maybe we don't need this loop any longer. > > I'd really prefer it if we didn't tie the RIRB handing change to this loop > change, > removing th

Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Pierre-Louis Bossart
I added debug messages to print the RIRBWP register and realize that response could come between the read of RIRBWP in the snd_hdac_bus_update_rirb() function and the interrupt clear in the hda_dsp_stream_interrupt() function. The response is not handled but the interrupt is already cleared. It

Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Takashi Iwai
On Thu, 11 Jun 2020 20:12:53 +0200, Ranjani Sridharan wrote: > > On Thu, 2020-06-11 at 19:59 +0200, Takashi Iwai wrote: > > On Thu, 11 Jun 2020 19:09:08 +0200, > > Lu, Brent wrote: > > > > > > > Hi Brent, > > > > > > > > Thanks for the patch. Is this fix for a specific issue you're > > > > seein

Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Ranjani Sridharan
On Thu, 2020-06-11 at 19:59 +0200, Takashi Iwai wrote: > On Thu, 11 Jun 2020 19:09:08 +0200, > Lu, Brent wrote: > > > > > Hi Brent, > > > > > > Thanks for the patch. Is this fix for a specific issue you're > > > seeing? > > > If so, could you please give us some details about it? > > > > > > Tha

Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Pierre-Louis Bossart
On 6/11/20 12:09 PM, Lu, Brent wrote: Hi Brent, Thanks for the patch. Is this fix for a specific issue you're seeing? If so, could you please give us some details about it? Thanks, Ranjani Hi Ranjani, It's reported to happen on GLK Chromebook 'Fleex' that sometimes it cannot output the au

Re: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Takashi Iwai
On Thu, 11 Jun 2020 19:09:08 +0200, Lu, Brent wrote: > > > Hi Brent, > > > > Thanks for the patch. Is this fix for a specific issue you're seeing? > > If so, could you please give us some details about it? > > > > Thanks, > > Ranjani > > Hi Ranjani, > > It's reported to happen on GLK Chromeboo

RE: [PATCH] ASoC: SOF: Intel: hda: unsolicited RIRB response

2020-06-11 Thread Lu, Brent
> Hi Brent, > > Thanks for the patch. Is this fix for a specific issue you're seeing? > If so, could you please give us some details about it? > > Thanks, > Ranjani Hi Ranjani, It's reported to happen on GLK Chromebook 'Fleex' that sometimes it cannot output the audio stream to external display