RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
On 03 May 2017 15:10, Takashi Sakamoto wrote: > On May 3 2017 22:54, Adam Thomson wrote: > > In the SRM lock check section of code the '&' bitwise operator is > > used as part of checking lock status. Functionally the code works > > as intended, but the conditional statement is a boolean

RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
On 03 May 2017 15:10, Takashi Sakamoto wrote: > On May 3 2017 22:54, Adam Thomson wrote: > > In the SRM lock check section of code the '&' bitwise operator is > > used as part of checking lock status. Functionally the code works > > as intended, but the conditional statement is a boolean

Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Takashi Sakamoto
On May 3 2017 22:54, Adam Thomson wrote: > In the SRM lock check section of code the '&' bitwise operator is > used as part of checking lock status. Functionally the code works > as intended, but the conditional statement is a boolean comparison > so should really use '&&' logical operator

Re: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Takashi Sakamoto
On May 3 2017 22:54, Adam Thomson wrote: > In the SRM lock check section of code the '&' bitwise operator is > used as part of checking lock status. Functionally the code works > as intended, but the conditional statement is a boolean comparison > so should really use '&&' logical operator