Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Lucas Stach
Am Dienstag, dem 20.04.2021 um 13:47 + schrieb Robin Gong: > On 2021/04/19 17:46 Lucas Stach wrote: > > Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > > > Hi Lucas, > > > > > > On 2021/04/14 Lucas Stach wrote: > > > > Hi Robin, > > > > > > > > Am Mittwoch, dem 14.04.2021 um

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Robin Gong
On 2021/04/19 17:46 Lucas Stach wrote: > Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > > Hi Lucas, > > > > On 2021/04/14 Lucas Stach wrote: > > > Hi Robin, > > > > > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > > > > On 2020/05/20 17:43 Lucas Stach wrote: >

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Lucas Stach
Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > Hi Lucas, > > On 2021/04/14 Lucas Stach wrote: > > Hi Robin, > > > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > > > On 2020/05/20 17:43 Lucas Stach wrote: > > > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrie

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Robin Gong
Hi Lucas, On 2021/04/14 Lucas Stach wrote: > Hi Robin, > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > > On 2020/05/20 17:43 Lucas Stach wrote: > > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > > > Hi > > > > > > > > On Tue, May 19, 2020 at 6:04 PM L

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Lucas Stach
Hi Robin, Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > On 2020/05/20 17:43 Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > > Hi > > > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > > wrote: > > > > Am Dienstag, den 19.05.2020,

RE: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Robin Gong
On 2020/05/20 17:43 Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements that we need to mov

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Mark Brown
On Thu, May 21, 2020 at 07:30:04PM +0800, Shengjiu Wang wrote: > On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > Other drivers having problems means those drivers should be fixed, not > > that we should copy the problems. In the case of the PXA driver that's > > very old code which predate

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-21 Thread Shengjiu Wang
On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > > > I see some driver also request dma channel in open() or hw_params(). > > how can they avoid the defer probe issue? > > for example： > > sound/arm/pxa2xx-pcm-lib.c > > sound/so

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Mark Brown
On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > I see some driver also request dma channel in open() or hw_params(). > how can they avoid the defer probe issue? > for example： > sound/arm/pxa2xx-pcm-lib.c > sound/soc/sprd/sprd-pcm-dma.c Other drivers having problems means those d

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Shengjiu Wang
Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements tha

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Lucas Stach
Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > Hi > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > There are two requirements that we need to move the request > > > of dma channel from probe to open

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Shengjiu Wang
Hi On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > There are two requirements that we need to move the request > > of dma channel from probe to open. > > How do you handle -EPROBE_DEFER return code from the channel request

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-19 Thread Lucas Stach
Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > There are two requirements that we need to move the request > of dma channel from probe to open. How do you handle -EPROBE_DEFER return code from the channel request if you don't do it in probe? > - When dma device binds with power