Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Josh Coombs
Digging back through the archives, this came up once in 2007, Alan Cox did not like the idea of globally adding this call into the critical paths of libata at the time. (I've seen it done via external patches in ata_qc_issue and ata_qc_complete for example.) If that concern is no longer in place,

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Jeff Garzik
On 01/08/2013 01:16 PM, Joshua Coombs wrote: Add a call to the IDE LED Trigger within the Marvell SATA driver to allow Marvell SoC devices to show SATA activity via GPIO connected LEDs. Signed-off-by: Joshua Coombs --- drivers/ata/sata_mv.c | 3 +++ drivers/leds/Kconfig | 3 +-- 2 files ch

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-09 Thread Josh Coombs
ason Cooper >> Sent: Wednesday, January 09, 2013 5:04 AM >> To: Josh Coombs >> Cc: coolo...@gmail.com; linux-kernel@vger.kernel.org; linux- >> i...@vger.kernel.org; rpur...@rpsys.net; linux ARM; jgar...@pobox.com; >> linux-l...@vger.kernel.org >> Subject: Re: [PATCH]

RE: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-08 Thread Kim, Milo
vger.kernel.org; rpur...@rpsys.net; linux ARM; jgar...@pobox.com; > linux-l...@vger.kernel.org > Subject: Re: [PATCH] Allow Marvell SATA driver to work with > LEDS_TRIGGER_IDE_DISK > > On Tue, Jan 08, 2013 at 02:18:04PM -0500, Josh Coombs wrote: > > Would it make more sense to

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-08 Thread Jason Cooper
On Tue, Jan 08, 2013 at 02:18:04PM -0500, Josh Coombs wrote: > On Tue, Jan 8, 2013 at 2:06 PM, Jason Cooper wrote: > > On Tue, Jan 08, 2013 at 01:16:27PM -0500, Joshua Coombs wrote: > >> Add a call to the IDE LED Trigger within the Marvell SATA driver to allow > >> Marvell SoC devices to show SATA

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-08 Thread Josh Coombs
I only have access to Marvell's SATA controller for testing, so that is why I only targeted it. The Kconfig depends change makes perfect sense. Changing the name of the trigger might cause hardship for those already using it, as they will have to update scripts/etc to account for the name change.

Re: [PATCH] Allow Marvell SATA driver to work with LEDS_TRIGGER_IDE_DISK

2013-01-08 Thread Jason Cooper
On Tue, Jan 08, 2013 at 01:16:27PM -0500, Joshua Coombs wrote: > Add a call to the IDE LED Trigger within the Marvell SATA driver to allow > Marvell SoC devices to show SATA activity via GPIO connected LEDs. > > Signed-off-by: Joshua Coombs > --- > drivers/ata/sata_mv.c | 3 +++ > drivers/leds/K