RE: [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver

>> How's that for a one-liner? ;) >- the return value from acpi_cpufreq_early_init() gets ignored, > so the module will still load, but won't work. >- Once that is fixed, the test for !acpi_perf_data[cpu] in > acpi_cpufreq_cpu_init() can be removed. We will modify code in those places. - To un

Re: [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver

On Thu, 26 Jul 2007 17:12:22 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > How's that for a one-liner? ;) - the return value from acpi_cpufreq_early_init() gets ignored, so the module will still load, but won't work. - Once that is fixed, the test for !acpi_perf_data[cpu] in acpi_cpufreq_

Re: [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver

On Thu, 26 Jul 2007 16:46:30 -0700 Fenghua Yu <[EMAIL PROTECTED]> wrote: > The local variable "covered" is used without initialization in i386 > acpi-cpufreq > driver. The initial value of covered should be 0. The bug will cause memory > leak > when hit. The following patch fixes this bug. > >

Re:[PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver

Updated patch: Use CPU_MASK_NONE for initil value. Signed-off-by: Fenghua Yu <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/ac