Re: [PATCH] IB/cxgb3: remove cxio_dbg.c

2018-01-30 Thread LABBE Corentin
On Sun, Jan 28, 2018 at 02:09:03PM -0700, Jason Gunthorpe wrote: > On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote: > > On Sun, 2018-01-28 at 15:11 +, Corentin Labbe wrote: > > > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: > > > cleanups") > > > 10 years after,

Re: [PATCH] IB/cxgb3: remove cxio_dbg.c

2018-01-28 Thread Jason Gunthorpe
On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote: > On Sun, 2018-01-28 at 15:11 +, Corentin Labbe wrote: > > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups") > > 10 years after, we could remove it. > > OK, now you could remove the prototypes and probably >

RE: [PATCH] IB/cxgb3: remove cxio_dbg.c

2018-01-28 Thread Steve Wise
> > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: > cleanups") > 10 years after, we could remove it. > > Signed-off-by: Corentin Labbe Acked-by: Steve Wise

Re: [PATCH] IB/cxgb3: remove cxio_dbg.c

2018-01-28 Thread Joe Perches
On Sun, 2018-01-28 at 15:11 +, Corentin Labbe wrote: > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups") > 10 years after, we could remove it. OK, now you could remove the prototypes and probably CONFIG_INFINIBAND_CXGB3_DEBUG too. There is a DEBUG test and many uses