RE: [PATCH] IB/qib: remove redundant setting of any in for-loop

2017-11-14 Thread Marciniszyn, Mike
> > Doug, do you want a tested patch from me? > > Preferably, yes :-) > These patches are in a two patch series: https://marc.info/?l=linux-rdma&m=151069497506923&w=2 The first is Colin's warning fix and the second is Joe's cleanup. My value add is the testing. :) They pass our psm testing.

Re: [PATCH] IB/qib: remove redundant setting of any in for-loop

2017-11-13 Thread Doug Ledford
On Fri, 2017-11-10 at 19:07 +, Marciniszyn, Mike wrote: > > > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote: > > > > From: Colin Ian King > > > > > > > > The variable all is being set but is never read after this > > > > hence it can be removed from the for loop initialization. > > > >

RE: [PATCH] IB/qib: remove redundant setting of any in for-loop

2017-11-10 Thread Marciniszyn, Mike
> > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote: > > > From: Colin Ian King > > > > > > The variable all is being set but is never read after this > > > hence it can be removed from the for loop initialization. > > > Cleans up clang warning: > > > > any is really used as bool and is initia

Re: [PATCH] IB/qib: remove redundant setting of any in for-loop

2017-11-10 Thread Doug Ledford
On Fri, 2017-10-20 at 00:35 -0700, Joe Perches wrote: > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote: > > From: Colin Ian King > > > > The variable all is being set but is never read after this > > hence it can be removed from the for loop initialization. > > Cleans up clang warning: > >

Re: [PATCH] IB/qib: remove redundant setting of any in for-loop

2017-10-20 Thread Joe Perches
On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote: > From: Colin Ian King > > The variable all is being set but is never read after this > hence it can be removed from the for loop initialization. > Cleans up clang warning: any is really used as bool and is initialized at function entry. The