RE: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq

2021-01-02 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Saturday, January 2, 2021 6:55 PM > To: Song Bao Hua (Barry Song) > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] Input: ar1021 - use IRQ

Re: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq

2021-01-01 Thread Dmitry Torokhov
Hi Barry, On Sat, Jan 02, 2021 at 05:29:02PM +1300, Barry Song wrote: > disable_irq() after request_irq is unsafe as it gives a time gap which > irq can come before disable_irq(). IRQ_NOAUTOEN is the common way to > avoid enabling IRQ due to requesting IRQ. Actually it is OK for the ISR to fire b