Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-23 Thread Kai-Heng Feng
> On Sep 18, 2020, at 01:20, Bjorn Helgaas wrote: > > On Thu, Sep 10, 2020 at 07:51:05PM +, Derrick, Jonathan wrote: >> On Thu, 2020-09-10 at 14:17 -0500, Bjorn Helgaas wrote: >>> On Thu, Sep 10, 2020 at 06:52:48PM +, Derrick, Jonathan wrote: On Thu, 2020-09-10 at 12:38 -0500,

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-17 Thread Bjorn Helgaas
On Thu, Sep 10, 2020 at 07:51:05PM +, Derrick, Jonathan wrote: > On Thu, 2020-09-10 at 14:17 -0500, Bjorn Helgaas wrote: > > On Thu, Sep 10, 2020 at 06:52:48PM +, Derrick, Jonathan wrote: > > > On Thu, 2020-09-10 at 12:38 -0500, Bjorn Helgaas wrote: > > > > On Thu, Sep 10, 2020 at

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-10 Thread Derrick, Jonathan
On Thu, 2020-09-10 at 14:17 -0500, Bjorn Helgaas wrote: > On Thu, Sep 10, 2020 at 06:52:48PM +, Derrick, Jonathan wrote: > > On Thu, 2020-09-10 at 12:38 -0500, Bjorn Helgaas wrote: > > > On Thu, Sep 10, 2020 at 04:33:39PM +, Derrick, Jonathan wrote: > > > > On Wed, 2020-09-09 at 20:55

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-10 Thread Bjorn Helgaas
On Thu, Sep 10, 2020 at 06:52:48PM +, Derrick, Jonathan wrote: > On Thu, 2020-09-10 at 12:38 -0500, Bjorn Helgaas wrote: > > On Thu, Sep 10, 2020 at 04:33:39PM +, Derrick, Jonathan wrote: > > > On Wed, 2020-09-09 at 20:55 -0500, Bjorn Helgaas wrote: > > > > On Fri, Aug 21, 2020 at

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-10 Thread Bjorn Helgaas
On Thu, Sep 10, 2020 at 04:33:39PM +, Derrick, Jonathan wrote: > On Wed, 2020-09-09 at 20:55 -0500, Bjorn Helgaas wrote: > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > > > New Intel laptops with VMD cannot reach deeper power saving state, > > > renders very short battery

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-10 Thread Derrick, Jonathan
Hi Bjorn On Wed, 2020-09-09 at 20:55 -0500, Bjorn Helgaas wrote: > [+cc Saheed] > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > > New Intel laptops with VMD cannot reach deeper power saving state, > > renders very short battery time. > > > > As BIOS may not be able to

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-09 Thread Bjorn Helgaas
[+cc Saheed] On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. > > As BIOS may not be able to program the config space for devices under > VMD domain, ASPM needs to be programmed

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-02 Thread Keith Busch
On Wed, Sep 02, 2020 at 01:48:19PM -0600, David Fugate wrote: > Over the years, I've been forwarded numerous emails from VMD customers > praising it's ability to prevent Linux kernel panics upon hot-removals > and inserts of U.2 NVMe drives. The same nvme and pcie hotplug drivers are used with

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-09-02 Thread David Fugate
On Tue, 2020-08-25 at 07:56 +0100, Christoph Hellwig wrote: > while adding absolutely no value. Basically we have to add a large > chunk of kernel code just to undo silicone/firmware Intel added to > their > platform to make things complicated. I mean it is their platform and > if > they want a

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-29 Thread h...@infradead.org
On Thu, Aug 27, 2020 at 05:49:40PM +, Limonciello, Mario wrote: > Can you further elaborate what exactly you're wanting here? VMD > enable/disable > is something that is configured in firmware setup as the firmware does the > early > configuration for the silicon related to it. So it's up

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-29 Thread h...@infradead.org
On Thu, Aug 27, 2020 at 02:33:56PM -0700, Dan Williams wrote: > > Just a few benefits and there are other users with unique use cases: > > 1. Passthrough of the endpoint to OSes which don't natively support > > hotplug can enable hotplug for that OS using the guest VMD driver > > 2. Some

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread Dan Williams
On Thu, Aug 27, 2020 at 9:46 AM Derrick, Jonathan wrote: > > On Thu, 2020-08-27 at 17:23 +0100, h...@infradead.org wrote: > > On Thu, Aug 27, 2020 at 04:13:44PM +, Derrick, Jonathan wrote: > > > On Thu, 2020-08-27 at 06:34 +, h...@infradead.org wrote: > > > > On Wed, Aug 26, 2020 at

RE: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread Limonciello, Mario
> > I don't see the purpose of this line of discussion. VMD has been in the > > kernel for 5 years. We are constantly working on better support. > > Please just work with the platform people to allow the host to disable > VMD. That is the only really useful value add here. Can you further

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread h...@infradead.org
On Thu, Aug 27, 2020 at 04:45:53PM +, Derrick, Jonathan wrote: > Just a few benefits and there are other users with unique use cases: > 1. Passthrough of the endpoint to OSes which don't natively support > hotplug can enable hotplug for that OS using the guest VMD driver Or they could just

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread Derrick, Jonathan
On Thu, 2020-08-27 at 17:23 +0100, h...@infradead.org wrote: > On Thu, Aug 27, 2020 at 04:13:44PM +, Derrick, Jonathan wrote: > > On Thu, 2020-08-27 at 06:34 +, h...@infradead.org wrote: > > > On Wed, Aug 26, 2020 at 09:43:27PM +, Derrick, Jonathan wrote: > > > > Feel free to review my

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread h...@infradead.org
On Thu, Aug 27, 2020 at 04:13:44PM +, Derrick, Jonathan wrote: > On Thu, 2020-08-27 at 06:34 +, h...@infradead.org wrote: > > On Wed, Aug 26, 2020 at 09:43:27PM +, Derrick, Jonathan wrote: > > > Feel free to review my set to disable the MSI remapping which will > > > make > > > it

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread Derrick, Jonathan
On Thu, 2020-08-27 at 06:34 +, h...@infradead.org wrote: > On Wed, Aug 26, 2020 at 09:43:27PM +, Derrick, Jonathan wrote: > > Feel free to review my set to disable the MSI remapping which will > > make > > it perform as well as direct-attached: > > > >

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-27 Thread h...@infradead.org
On Wed, Aug 26, 2020 at 09:43:27PM +, Derrick, Jonathan wrote: > Feel free to review my set to disable the MSI remapping which will make > it perform as well as direct-attached: > > https://patchwork.kernel.org/project/linux-pci/list/?series=325681 So that then we have to deal with your

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-26 Thread Derrick, Jonathan
On Tue, 2020-08-25 at 06:23 +, Christoph Hellwig wrote: > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > > New Intel laptops with VMD cannot reach deeper power saving state, > > renders very short battery time. > > So what about just disabling VMD given how bloody pointless

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai-Heng Feng
> On Aug 25, 2020, at 14:56, Christoph Hellwig wrote: > > On Tue, Aug 25, 2020 at 02:39:55PM +0800, Kai Heng Feng wrote: >> Hi Christoph, >> >>> On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: >>> >>> On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: New Intel

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Christoph Hellwig
On Tue, Aug 25, 2020 at 02:39:55PM +0800, Kai Heng Feng wrote: > Hi Christoph, > > > On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: > > > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > >> New Intel laptops with VMD cannot reach deeper power saving state, > >> renders

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai Heng Feng
Hi Christoph, > On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: >> New Intel laptops with VMD cannot reach deeper power saving state, >> renders very short battery time. > > So what about just disabling VMD given how

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Christoph Hellwig
On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. So what about just disabling VMD given how bloody pointless it is? Hasn't anyone learned from the AHCI remapping debacle? I'm

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-24 Thread Mika Westerberg
Hi, On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. > > As BIOS may not be able to program the config space for devices under > VMD domain, ASPM needs to be programmed manually