RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-27 Thread Bing Zhao
> I didn't get the same result..In my case, it's working fine. > But as Bing's result, i will check more and share the result. I want to add that my kernel is from "cros/release-R26-3701.B" branch with this HEAD: 4e13a9c CHERRY-PICK: UPSTREAM: loop: prevent bdev freeing while device in use

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-27 Thread Bing Zhao
I didn't get the same result..In my case, it's working fine. But as Bing's result, i will check more and share the result. I want to add that my kernel is from cros/release-R26-3701.B branch with this HEAD: 4e13a9c CHERRY-PICK: UPSTREAM: loop: prevent bdev freeing while device in use

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-26 Thread Jaehoon Chung
Hi Seungwon, I didn't get the same result..In my case, it's working fine. But as Bing's result, i will check more and share the result. Best Regards, Jaehoon Chung On 06/26/2013 10:53 AM, Seungwon Jeon wrote: > Hi Jaehoon, > Do you have the same result? > Could you share the result? > >

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-26 Thread Jaehoon Chung
Hi Seungwon, I didn't get the same result..In my case, it's working fine. But as Bing's result, i will check more and share the result. Best Regards, Jaehoon Chung On 06/26/2013 10:53 AM, Seungwon Jeon wrote: Hi Jaehoon, Do you have the same result? Could you share the result? Thanks,

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-25 Thread Seungwon Jeon
Hi Jaehoon, Do you have the same result? Could you share the result? Thanks, Seungwon Jeon On Tuesday, June 25 2013, Bing Zhao wrote: > > I think the proposal on the table is to take Seungwon's patches > > instead of mine. Assuming they solve your problems, I'm OK with that. > > I think he was

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-25 Thread Seungwon Jeon
Hi Jaehoon, Do you have the same result? Could you share the result? Thanks, Seungwon Jeon On Tuesday, June 25 2013, Bing Zhao wrote: I think the proposal on the table is to take Seungwon's patches instead of mine. Assuming they solve your problems, I'm OK with that. I think he was

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-24 Thread Bing Zhao
> I think the proposal on the table is to take Seungwon's patches > instead of mine. Assuming they solve your problems, I'm OK with that. > I think he was requesting testing the first of his two patches alone > and then both of his two patches together. Test #1: Swungwon's patch #1 alone [1]

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-24 Thread Bing Zhao
I think the proposal on the table is to take Seungwon's patches instead of mine. Assuming they solve your problems, I'm OK with that. I think he was requesting testing the first of his two patches alone and then both of his two patches together. Test #1: Swungwon's patch #1 alone [1] Test

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-20 Thread Doug Anderson
Bing, On Tue, Jun 18, 2013 at 1:01 PM, Bing Zhao wrote: > Hi Doug, > >> > I tested Doug's patch on my failing unit. >> > >> > Without this patch, mmc got hung_task and rebooted eventually. >> > With this patch applied, mmc returns CRC error instead of hung_task, and >> > the error is handled >>

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-20 Thread Doug Anderson
Bing, On Tue, Jun 18, 2013 at 1:01 PM, Bing Zhao bz...@marvell.com wrote: Hi Doug, I tested Doug's patch on my failing unit. Without this patch, mmc got hung_task and rebooted eventually. With this patch applied, mmc returns CRC error instead of hung_task, and the error is handled

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-19 Thread Jaehoon Chung
Hi All, I tested with Seungwon's patch and this patch. I'm agreed with Seungwon's opinion. Best Regards, Jaehoon Chung On 06/18/2013 09:36 PM, Seungwon Jeon wrote: > On Thursday, June 13, 2013, Doug Anderson wrote: >> Seungwon, >> >> On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon wrote: >

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-19 Thread Jaehoon Chung
Hi All, I tested with Seungwon's patch and this patch. I'm agreed with Seungwon's opinion. Best Regards, Jaehoon Chung On 06/18/2013 09:36 PM, Seungwon Jeon wrote: On Thursday, June 13, 2013, Doug Anderson wrote: Seungwon, On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon tgih@samsung.com

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Bing Zhao
Hi Doug, > > I tested Doug's patch on my failing unit. > > > > Without this patch, mmc got hung_task and rebooted eventually. > > With this patch applied, mmc returns CRC error instead of hung_task, and > > the error is handled > gracefully. > > Have you tried one or both or Seungwon's fixes

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Doug Anderson
Bing, On Tue, Jun 18, 2013 at 12:46 PM, Bing Zhao wrote: > Hi Seungwon, > >> > I don't have the failing unit myself, so we'll have to get Bing to try >> > the patches. You are suggesting that we try applying both of your >> > patches, right? >> Did you test the patch? >> I wonder that both are

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Bing Zhao
Hi Seungwon, > > I don't have the failing unit myself, so we'll have to get Bing to try > > the patches. You are suggesting that we try applying both of your > > patches, right? > Did you test the patch? > I wonder that both are good for your side. I tested Doug's patch on my failing unit.

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Seungwon Jeon
On Thursday, June 13, 2013, Doug Anderson wrote: > Seungwon, > > On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon wrote: > >> > There are two solutions we have applied. > >> > >> I'm a little confused. Have you already applied one or both of the > >> solutions you list below, or are you

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Seungwon Jeon
On Thursday, June 13, 2013, Doug Anderson wrote: Seungwon, On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon tgih@samsung.com wrote: There are two solutions we have applied. I'm a little confused. Have you already applied one or both of the solutions you list below, or are you

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Bing Zhao
Hi Seungwon, I don't have the failing unit myself, so we'll have to get Bing to try the patches. You are suggesting that we try applying both of your patches, right? Did you test the patch? I wonder that both are good for your side. I tested Doug's patch on my failing unit. Without

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Doug Anderson
Bing, On Tue, Jun 18, 2013 at 12:46 PM, Bing Zhao bz...@marvell.com wrote: Hi Seungwon, I don't have the failing unit myself, so we'll have to get Bing to try the patches. You are suggesting that we try applying both of your patches, right? Did you test the patch? I wonder that both

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-18 Thread Bing Zhao
Hi Doug, I tested Doug's patch on my failing unit. Without this patch, mmc got hung_task and rebooted eventually. With this patch applied, mmc returns CRC error instead of hung_task, and the error is handled gracefully. Have you tried one or both or Seungwon's fixes without mine?

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-12 Thread Doug Anderson
Seungwon, On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon wrote: >> > There are two solutions we have applied. >> >> I'm a little confused. Have you already applied one or both of the >> solutions you list below, or are you proposing them as alternates to >> the patch I submitted? > Yes, first

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-06-12 Thread Doug Anderson
Seungwon, On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon tgih@samsung.com wrote: There are two solutions we have applied. I'm a little confused. Have you already applied one or both of the solutions you list below, or are you proposing them as alternates to the patch I submitted?

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-10 Thread Jaehoon Chung
On 04/10/2013 04:02 PM, Seungwon Jeon wrote: > On Tuesday, April 09, 2013, Doug Anderson wrote: >> Seungwon, >> >> On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote: >>> I guess Doug are debugging it with wifi, right? >> >> Yes, we're debugging it on the Samsung ARM Chromebook on a part that >>

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-10 Thread Seungwon Jeon
On Tuesday, April 09, 2013, Doug Anderson wrote: > Seungwon, > > On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote: > > I guess Doug are debugging it with wifi, right? > > Yes, we're debugging it on the Samsung ARM Chromebook on a part that > has an SDIO WiFi module by Marvell. Bing Zhao

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-10 Thread Seungwon Jeon
On Tuesday, April 09, 2013, Doug Anderson wrote: Seungwon, On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon tgih@samsung.com wrote: I guess Doug are debugging it with wifi, right? Yes, we're debugging it on the Samsung ARM Chromebook on a part that has an SDIO WiFi module by Marvell.

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-10 Thread Jaehoon Chung
On 04/10/2013 04:02 PM, Seungwon Jeon wrote: On Tuesday, April 09, 2013, Doug Anderson wrote: Seungwon, On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon tgih@samsung.com wrote: I guess Doug are debugging it with wifi, right? Yes, we're debugging it on the Samsung ARM Chromebook on a part

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Doug Anderson
Seungwon, On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote: > I guess Doug are debugging it with wifi, right? Yes, we're debugging it on the Samsung ARM Chromebook on a part that has an SDIO WiFi module by Marvell. Bing Zhao (CCed) has a unit in hand that generates lots of CRC errors and

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Seungwon Jeon
On Friday, April 05, 2013, Jaehoon Chung wrote: > Hi Doug, > > You're right..it's something wrong. > Actually i didn't test with your patch, but your commit message is reasonable. > > I will check until next week after test. Doug Anderson, Jaehoon Chung, Sorry for late response. Could I explain

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Seungwon Jeon
On Friday, April 05, 2013, Jaehoon Chung wrote: Hi Doug, You're right..it's something wrong. Actually i didn't test with your patch, but your commit message is reasonable. I will check until next week after test. Doug Anderson, Jaehoon Chung, Sorry for late response. Could I explain this

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-08 Thread Doug Anderson
Seungwon, On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon tgih@samsung.com wrote: I guess Doug are debugging it with wifi, right? Yes, we're debugging it on the Samsung ARM Chromebook on a part that has an SDIO WiFi module by Marvell. Bing Zhao (CCed) has a unit in hand that generates lots

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-07 Thread Jaehoon Chung
Looks good to me. Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung On 04/05/2013 05:18 PM, Jaehoon Chung wrote: > Hi Doug, > > You're right..it's something wrong. > Actually i didn't test with your patch, but your commit message is reasonable. > > I will check until next week after

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-07 Thread Jaehoon Chung
Looks good to me. Reviewed-by: Jaehoon Chung jh80.ch...@samsung.com Best Regards, Jaehoon Chung On 04/05/2013 05:18 PM, Jaehoon Chung wrote: Hi Doug, You're right..it's something wrong. Actually i didn't test with your patch, but your commit message is reasonable. I will check until

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-05 Thread Jaehoon Chung
Hi Doug, You're right..it's something wrong. Actually i didn't test with your patch, but your commit message is reasonable. I will check until next week after test. Best Regards, Jaehoon Chung On 03/27/2013 03:06 AM, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 18, 2013 at 3:21 AM, Jaehoon

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-04-05 Thread Jaehoon Chung
Hi Doug, You're right..it's something wrong. Actually i didn't test with your patch, but your commit message is reasonable. I will check until next week after test. Best Regards, Jaehoon Chung On 03/27/2013 03:06 AM, Doug Anderson wrote: Jaehoon, On Mon, Mar 18, 2013 at 3:21 AM, Jaehoon

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-03-26 Thread Doug Anderson
Jaehoon, On Mon, Mar 18, 2013 at 3:21 AM, Jaehoon Chung wrote: > Hi Doug, > > Great..i have found the problem like this. > I will check your patch..and share the result. Did you have any time to check this patch? Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-03-26 Thread Doug Anderson
Jaehoon, On Mon, Mar 18, 2013 at 3:21 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Doug, Great..i have found the problem like this. I will check your patch..and share the result. Did you have any time to check this patch? Thanks! -Doug -- To unsubscribe from this list: send the line

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-03-18 Thread Jaehoon Chung
Hi Doug, Great..i have found the problem like this. I will check your patch..and share the result. Best Regards, Jaehoon Chung On 03/16/2013 06:29 AM, Doug Anderson wrote: > On a flaky piece of hardware that seems good at generating CRC errors, > we have found that often times the CRC errors

Re: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

2013-03-18 Thread Jaehoon Chung
Hi Doug, Great..i have found the problem like this. I will check your patch..and share the result. Best Regards, Jaehoon Chung On 03/16/2013 06:29 AM, Doug Anderson wrote: On a flaky piece of hardware that seems good at generating CRC errors, we have found that often times the CRC errors