RE: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-25 Thread Pawel Laszczak
> >On 25/11/2020 02:36, Peter Chen wrote: >> On 20-11-24 14:22:25, Roger Quadros wrote: >>> Peter, >>> >>> On 24/11/2020 13:47, Peter Chen wrote: On 20-11-24 12:33:34, Roger Quadros wrote: I am sorry about that. Do you use role switch /sys entry, if you have used, I

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-25 Thread Roger Quadros
On 25/11/2020 02:36, Peter Chen wrote: On 20-11-24 14:22:25, Roger Quadros wrote: Peter, On 24/11/2020 13:47, Peter Chen wrote: On 20-11-24 12:33:34, Roger Quadros wrote: I am sorry about that. Do you use role switch /sys entry, if you have used, I prefer using "usb-role-switch" property

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Peter Chen
On 20-11-24 14:22:25, Roger Quadros wrote: > Peter, > > On 24/11/2020 13:47, Peter Chen wrote: > > On 20-11-24 12:33:34, Roger Quadros wrote: > > > > > > > > > > > > I am sorry about that. Do you use role switch /sys entry, if you > > > > > > have > > > > > > used, I prefer using

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Roger Quadros
Peter, On 24/11/2020 13:47, Peter Chen wrote: On 20-11-24 12:33:34, Roger Quadros wrote: I am sorry about that. Do you use role switch /sys entry, if you have used, I prefer using "usb-role-switch" property at dts to judge if SoC OTG signals or external signals for role switch. If you have

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Peter Chen
On 20-11-24 12:33:34, Roger Quadros wrote: > > > > > > > > I am sorry about that. Do you use role switch /sys entry, if you have > > > > used, I prefer using "usb-role-switch" property at dts to judge if SoC > > > > OTG signals or external signals for role switch. If you have not used > > > > it,

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Heikki Krogerus
om: Roger Quadros > > > Sent: 2020年11月24日 17:39 > > > To: Peter Chen > > > Cc: paw...@cadence.com; gre...@linuxfoundation.org; ba...@kernel.org; > > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] Revert "usb: cdns3:

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Roger Quadros
@vger.kernel.org Subject: Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class" Peter, On 24/11/2020 08:43, Peter Chen wrote: On 20-11-23 13:50:51, Roger Quadros wrote: This reverts commit 50642709f6590fe40afa6d22c32f23f5b842aed5. This commit breaks hardware based role switc

RE: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Peter Chen
H] Revert "usb: cdns3: core: quit if it uses role switch > class" > > Peter, > > On 24/11/2020 08:43, Peter Chen wrote: > > On 20-11-23 13:50:51, Roger Quadros wrote: > >> This reverts commit 50642709f6590fe40afa6d22c32f23f5b842aed5. > >> > >&

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-24 Thread Roger Quadros
Peter, On 24/11/2020 08:43, Peter Chen wrote: On 20-11-23 13:50:51, Roger Quadros wrote: This reverts commit 50642709f6590fe40afa6d22c32f23f5b842aed5. This commit breaks hardware based role switching on TI platforms. cdns->role_sw is always going to be non-zero as it is a pointer to the

Re: [PATCH] Revert "usb: cdns3: core: quit if it uses role switch class"

2020-11-23 Thread Peter Chen
On 20-11-23 13:50:51, Roger Quadros wrote: > This reverts commit 50642709f6590fe40afa6d22c32f23f5b842aed5. > > This commit breaks hardware based role switching on TI platforms. > cdns->role_sw is always going to be non-zero as it is a pointer > to the usb_role_switch instance. Some other means