Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

2019-08-07 Thread Anshuman Khandual
Catalin >> Marinas ; Will Deacon ; >> Mark Rutland ; James Morse >> >> Cc: Christoffer Dall ; Punit Agrawal >> ; Qian Cai ; Jun Yao >> ; Alex Van Brunt ; >> Robin Murphy ; Thomas Gleixner >> ; linux-arm-ker...@lists.infradead.org; linux- >&g

RE: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

2019-08-07 Thread Justin He (Arm Technology China)
fer Dall ; Punit Agrawal > ; Qian Cai ; Jun Yao > ; Alex Van Brunt ; > Robin Murphy ; Thomas Gleixner > ; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in > pte_mkdevmap on arm64 > [...] > >

Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

2019-08-07 Thread Anshuman Khandual
On 08/07/2019 10:28 AM, Jia He wrote: > Without this patch, the MAP_SYNC test case will cause a print_bad_pte > warning on arm64 as follows: > [ 25.542693] BUG: Bad page map in process mapdax333 > pte:2e8000448800f53 pmd:41ff5f003 > [ 25.546360] page:7e001022 refcount:1 mapcount:-1 >

Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

2019-08-07 Thread Catalin Marinas
On Wed, Aug 07, 2019 at 10:09:29AM +0100, Will Deacon wrote: > On Wed, Aug 07, 2019 at 12:58:51PM +0800, Jia He wrote: > > diff --git a/arch/arm64/include/asm/pgtable.h > > b/arch/arm64/include/asm/pgtable.h > > index 5fdcfe237338..e09760ece844 100644 > > --- a/arch/arm64/include/asm/pgtable.h > >

Re: [PATCH] arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64

2019-08-07 Thread Will Deacon
On Wed, Aug 07, 2019 at 12:58:51PM +0800, Jia He wrote: > diff --git a/arch/arm64/include/asm/pgtable.h > b/arch/arm64/include/asm/pgtable.h > index 5fdcfe237338..e09760ece844 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -209,7 +209,7 @@ static inli