Re: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

2015-11-18 Thread Ian Abbott
On 14/11/15 13:24, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/pcmmio.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-

Re: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

2015-11-11 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Nov 11, 2015 at 07:15:28PM +0530, Ranjith T wrote: > Is this patch is fine?.. You sent it a few days ago, please wait at least 2 weeks before worrying if a patch is accepted or not, we all are

Re: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T
Is this patch is fine?.. Thanks, Ranjith T. On Mon, Nov 9, 2015 at 11:14 PM, Ranjith T wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith T > --- > drivers/staging/comedi/drivers/pcmmio.c | 44 > +++

RE: [PATCH] comedi: pcmmio: Fix coding style - use BIT macro

2015-11-09 Thread Hartley Sweeten
On Monday, November 09, 2015 8:09 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith > --- > drivers/staging/comedi/drivers/pcmmio.c | 44 > +++ > 1 file changed, 22 inserti