RE: [PATCH] cpufreq: governor: Fix prev_load initialization in cpufreq_governor_start()

2016-04-25 Thread Chen, Yu C
Hi, > -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Monday, April 25, 2016 9:08 AM > To: Linux PM list > Cc: Linux Kernel Mailing List; Viresh Kumar; Chen, Yu C > Subject: [PATCH] cpufreq: governor: Fix prev_load initialization in > cpufreq_governor_start

Re: [PATCH] cpufreq: governor: Fix prev_load initialization in cpufreq_governor_start()

2016-04-25 Thread Viresh Kumar
On 25-04-16, 13:24, Rafael J. Wysocki wrote: > On Mon, Apr 25, 2016 at 6:14 AM, Viresh Kumar wrote: > > On 25-04-16, 03:07, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> The way cpufreq_governor_start() initializes j_cdbs->prev_load is > >> questionable. > >> > >> First off, j_c

Re: [PATCH] cpufreq: governor: Fix prev_load initialization in cpufreq_governor_start()

2016-04-25 Thread Rafael J. Wysocki
On Mon, Apr 25, 2016 at 6:14 AM, Viresh Kumar wrote: > On 25-04-16, 03:07, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> The way cpufreq_governor_start() initializes j_cdbs->prev_load is >> questionable. >> >> First off, j_cdbs->prev_cpu_wall used as a denominator in the >> computatio

Re: [PATCH] cpufreq: governor: Fix prev_load initialization in cpufreq_governor_start()

2016-04-24 Thread Viresh Kumar
On 25-04-16, 03:07, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The way cpufreq_governor_start() initializes j_cdbs->prev_load is > questionable. > > First off, j_cdbs->prev_cpu_wall used as a denominator in the > computation may be zero. The case this happens is when > get_cpu_idle_