Hi Vinod,
eDMA sullpies the data transmission service for other IPs, so it should be
suspended later and resumed earlier.
For example:
Synchronous Audio Interface (SAI), SAI use DMA to transfer the data.
When suspend:
1, SAI using suspend handlers to stop the DMA transmission.
2, DMA using
On Wed, Jul 15, 2015 at 05:32:58PM +0800, Yuan Yao wrote:
> +
> +static const struct dev_pm_ops fsl_edma_pm_ops = {
> + .suspend_late = fsl_edma_suspend_late,
> + .resume_early = fsl_edma_resume_early,
any reason why you are using early/late handlers?
--
~Vinod
--
To unsubscribe
Hi Arnd,
Ok, I will remove the #ifdef in the next version.
Thanks.
Hi All,
Is there any others comments?
Thanks for your review.
Best Regards,
Yuan Yao
On Wednesday, July 15, 2015 10:55 PM Arnd wrote:
> On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
> > Hi Arnd,
> >
> > Thanks for your
Hi Arnd,
Ok, I will remove the #ifdef in the next version.
Thanks.
Hi All,
Is there any others comments?
Thanks for your review.
Best Regards,
Yuan Yao
On Wednesday, July 15, 2015 10:55 PM Arnd wrote:
On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
Hi Arnd,
Thanks for your review.
On Wed, Jul 15, 2015 at 05:32:58PM +0800, Yuan Yao wrote:
+
+static const struct dev_pm_ops fsl_edma_pm_ops = {
+ .suspend_late = fsl_edma_suspend_late,
+ .resume_early = fsl_edma_resume_early,
any reason why you are using early/late handlers?
--
~Vinod
--
To unsubscribe from
Hi Vinod,
eDMA sullpies the data transmission service for other IPs, so it should be
suspended later and resumed earlier.
For example:
Synchronous Audio Interface (SAI), SAI use DMA to transfer the data.
When suspend:
1, SAI using suspend handlers to stop the DMA transmission.
2, DMA using
On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
> Hi Arnd,
>
> Thanks for your review.
> And can you give me more information?
> In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM
> support. So why not use the #ifdefs to remove the
> unnecessary code? Since the PM will not
.com; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support
>
> On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote:
> > +#ifdef CONFIG_PM
> > +enum fsl_edma_pm_state {
> > + RUNNING = 0,
> > + SUSPENDE
On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote:
> +#ifdef CONFIG_PM
> +enum fsl_edma_pm_state {
> + RUNNING = 0,
> + SUSPENDED,
> +};
> +#endif
>
> struct fsl_edma_hw_tcd {
>
The #ifdefs here seem unnecessary, at least most of them, better
just do this all unconditionally.
On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote:
+#ifdef CONFIG_PM
+enum fsl_edma_pm_state {
+ RUNNING = 0,
+ SUSPENDED,
+};
+#endif
struct fsl_edma_hw_tcd {
The #ifdefs here seem unnecessary, at least most of them, better
just do this all unconditionally.
Arnd
Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support
On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote:
+#ifdef CONFIG_PM
+enum fsl_edma_pm_state {
+ RUNNING = 0,
+ SUSPENDED,
+};
+#endif
struct fsl_edma_hw_tcd {
The #ifdefs here seem
On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
Hi Arnd,
Thanks for your review.
And can you give me more information?
In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM
support. So why not use the #ifdefs to remove the
unnecessary code? Since the PM will not be
12 matches
Mail list logo
