Re: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 03:00:49AM +, Peter Chen wrote: > > > On Tue, Mar 10, 2015 at 02:02:44AM +, Peter Chen wrote: > > > > > > > > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > > @@ -1803,7 +1803,7 @@ static int lpc32xx_ep_queue

RE: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-09 Thread Peter Chen
> On Tue, Mar 10, 2015 at 02:02:44AM +, Peter Chen wrote: > > > > > > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > @@ -1803,7 +1803,7 @@ static int lpc32xx_ep_queue(struct usb_ep *_ep, > > > > req = container_of(_req, struct lpc

Re: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-09 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 02:02:44AM +, Peter Chen wrote: > > > > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > > > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > > > @@ -1803,7 +1803,7 @@ static int lpc32xx_ep_queue(struct usb_ep *_ep, > > > req = container_of(_req, struct lpc32xx_request, req)

RE: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-09 Thread Peter Chen
> > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > > @@ -1803,7 +1803,7 @@ static int lpc32xx_ep_queue(struct usb_ep *_ep, > > req = container_of(_req, struct lpc32xx_request, req); > > ep = container_of(_ep, struct lpc32xx_ep, ep); > > > > -

Re: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-09 Thread Felipe Balbi
On Wed, Mar 04, 2015 at 09:11:19AM +0800, Peter Chen wrote: > On Tue, Mar 03, 2015 at 06:28:42PM +0530, Tapasweni Pathak wrote: > > This patch fixes multiple instances of null pointer dereference in this > > code. > > > > ep->udc is assigned to udc. ep is just an offset from _ep. _ep is then > >

Re: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-03 Thread Peter Chen
On Tue, Mar 03, 2015 at 06:28:42PM +0530, Tapasweni Pathak wrote: > This patch fixes multiple instances of null pointer dereference in this code. > > ep->udc is assigned to udc. ep is just an offset from _ep. _ep is then > checked for NULL. udc is dereferenced under the NULL check for _ep, making