RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Deucher, Alexander
> -Original Message- > From: Andrew Shadura [mailto:andrew.shad...@collabora.co.uk] > Sent: Thursday, November 03, 2016 6:09 AM > To: linux-kernel@vger.kernel.org; dri-de...@lists.freedesktop.org; Deucher, > Alexander; Koenig, Christian; David Airlie > Cc: Zhu, Rex; Jammy Zhou > Subject:

RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Deucher, Alexander
> -Original Message- > From: Andrew Shadura [mailto:andrew.shad...@collabora.co.uk] > Sent: Thursday, November 03, 2016 6:09 AM > To: linux-kernel@vger.kernel.org; dri-de...@lists.freedesktop.org; Deucher, > Alexander; Koenig, Christian; David Airlie > Cc: Zhu, Rex; Jammy Zhou > Subject:

RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Deucher, Alexander
mmy Zhou > Subject: Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL > > On 03/11/16 17:39, Deucher, Alexander wrote: > >> Returning -EINVAL from a bool-returning function > >> phm_check_smc_update_required_for_display_configuration has an > >> unexp

RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Deucher, Alexander
mmy Zhou > Subject: Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL > > On 03/11/16 17:39, Deucher, Alexander wrote: > >> Returning -EINVAL from a bool-returning function > >> phm_check_smc_update_required_for_display_configuration has an > >> unexp

Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Andrew Shadura
On 03/11/16 17:39, Deucher, Alexander wrote: >> Returning -EINVAL from a bool-returning function >> phm_check_smc_update_required_for_display_configuration has an >> unexpected >> effect of returning true, which is probably not what was intended. >> Replace -EINVAL by false. >> >> The only place

Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

2016-11-03 Thread Andrew Shadura
On 03/11/16 17:39, Deucher, Alexander wrote: >> Returning -EINVAL from a bool-returning function >> phm_check_smc_update_required_for_display_configuration has an >> unexpected >> effect of returning true, which is probably not what was intended. >> Replace -EINVAL by false. >> >> The only place