Re: [PATCH] incorrect direct io error handling

2007-01-10 Thread Dmitriy Monakhov
Sorry for long delay (russian holidays are very hard time :) ) David Chinner <[EMAIL PROTECTED]> writes: > On Tue, Dec 19, 2006 at 09:07:12AM +0300, Dmitriy Monakhov wrote: >> David Chinner <[EMAIL PROTECTED]> writes: >> > On Mon, Dec 18, 2006 at 04:22:44PM +0300, Dmitriy Monakhov wrote: >> >> di

Re: [PATCH] incorrect direct io error handling

2006-12-20 Thread David Chinner
On Tue, Dec 19, 2006 at 09:07:12AM +0300, Dmitriy Monakhov wrote: > David Chinner <[EMAIL PROTECTED]> writes: > > On Mon, Dec 18, 2006 at 04:22:44PM +0300, Dmitriy Monakhov wrote: > >> diff --git a/mm/filemap.c b/mm/filemap.c > >> index 8332c77..7c571dd 100644 > >> --- a/mm/filemap.c > >> +++ b/mm/

Re: [PATCH] incorrect direct io error handling

2006-12-18 Thread Dmitriy Monakhov
"Chen, Kenneth W" <[EMAIL PROTECTED]> writes: > Dmitriy Monakhov wrote on Monday, December 18, 2006 5:23 AM >> This patch is result of discussion started week ago here: >> http://lkml.org/lkml/2006/12/11/66 >> changes from original patch: >> - Update wrong comments about i_mutex locking. >> - Ad

Re: [PATCH] incorrect direct io error handling

2006-12-18 Thread Dmitriy Monakhov
David Chinner <[EMAIL PROTECTED]> writes: > On Mon, Dec 18, 2006 at 04:22:44PM +0300, Dmitriy Monakhov wrote: >> diff --git a/mm/filemap.c b/mm/filemap.c >> index 8332c77..7c571dd 100644 >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -2044,8 +2044,9 @@ generic_file_direct_write(struct kiocb * >

Re: [PATCH] incorrect direct io error handling

2006-12-18 Thread David Chinner
On Mon, Dec 18, 2006 at 04:22:44PM +0300, Dmitriy Monakhov wrote: > diff --git a/mm/filemap.c b/mm/filemap.c > index 8332c77..7c571dd 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2044,8 +2044,9 @@ generic_file_direct_write(struct kiocb * > /* >* Sync the fs metadata but not

RE: [PATCH] incorrect direct io error handling

2006-12-18 Thread Chen, Kenneth W
Dmitriy Monakhov wrote on Monday, December 18, 2006 5:23 AM > This patch is result of discussion started week ago here: > http://lkml.org/lkml/2006/12/11/66 > changes from original patch: > - Update wrong comments about i_mutex locking. > - Add BUG_ON(!mutex_is_locked(..)) for non blkdev. > - v