Re: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Brendan Higgins
On Fri, Sep 6, 2019 at 9:08 AM Shuah Khan wrote: > > On 9/6/19 10:02 AM, Arnd Bergmann wrote: > > On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan wrote: > > > >>>config KUNIT > >>>bool "Enable support for unit tests (KUnit)" > >>> + depends on PRINTK > >>>help > >>>

Re: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Shuah Khan
On 9/6/19 10:02 AM, Arnd Bergmann wrote: On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan wrote: config KUNIT bool "Enable support for unit tests (KUnit)" + depends on PRINTK help Enables support for kernel unit tests (KUnit), a lightweight unit testing and

Re: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Arnd Bergmann
On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan wrote: > > config KUNIT > > bool "Enable support for unit tests (KUnit)" > > + depends on PRINTK > > help > > Enables support for kernel unit tests (KUnit), a lightweight unit > > testing and mocking framework for the

Re: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Shuah Khan
On 9/6/19 9:27 AM, Arnd Bergmann wrote: The vprintk_emit() function is not available when CONFIG_PRINTK is disabled: kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-Werror,-Wimplicit-function-declaration] I suppose without printk(), there is not much use in kunit

RE: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Tim.Bird
Minor spelling nit.. > -Original Message- > From: Arnd Bergmann > > The vprintk_emit() function is not available when CONFIG_PRINTK > is disabled: > > kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [- > Werror,-Wimplicit-function-declaration] > > I suppose