RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-26 Thread Bing Zhao
Hi Daniel, > > Do you have any concern for OLPC platforms with above change? If it doesn't > > seem to break OLPC I > will send a patch to the list. > > Looks fine to me. Thanks for investigating. Thanks. I've just sent the patch. Regards, Bing -- To unsubscribe from this list: send the line

Re: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-26 Thread Daniel Drake
On Mon, Feb 25, 2013 at 5:21 PM, Bing Zhao wrote: > Do you have any concern for OLPC platforms with above change? If it doesn't > seem to break OLPC I will send a patch to the list. Looks fine to me. Thanks for investigating. Daniel -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-26 Thread Daniel Drake
On Mon, Feb 25, 2013 at 5:21 PM, Bing Zhao bz...@marvell.com wrote: Do you have any concern for OLPC platforms with above change? If it doesn't seem to break OLPC I will send a patch to the list. Looks fine to me. Thanks for investigating. Daniel -- To unsubscribe from this list: send the

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-26 Thread Bing Zhao
Hi Daniel, Do you have any concern for OLPC platforms with above change? If it doesn't seem to break OLPC I will send a patch to the list. Looks fine to me. Thanks for investigating. Thanks. I've just sent the patch. Regards, Bing -- To unsubscribe from this list: send the line

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-25 Thread Bing Zhao
Hi Daniel, > > There seems to be a race condition in lbs_thread(). > > > > At line 582: > > 582 if (!priv->fw_ready) > > 583 continue; > > > > The fw_ready is 0, so you never get the chance to execute the FUNC_INIT > > command. > > > > 617

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-25 Thread Bing Zhao
Hi Daniel, There seems to be a race condition in lbs_thread(). At line 582: 582 if (!priv-fw_ready) 583 continue; The fw_ready is 0, so you never get the chance to execute the FUNC_INIT command. 617 /* Execute the

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-24 Thread Lubomir Rintel
On Wed, 2013-02-20 at 17:59 -0800, Bing Zhao wrote: > Hi Lubomir, > > > > > @@ -825,20 +825,6 @@ static void if_sdio_finish_power_on(struct > > > > if_sdio_card *card) > > > > > > > > sdio_release_host(func); > > > > > > > > - /* > > > > -* FUNC_INIT is required for SD8688

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-24 Thread Lubomir Rintel
On Wed, 2013-02-20 at 17:59 -0800, Bing Zhao wrote: Hi Lubomir, @@ -825,20 +825,6 @@ static void if_sdio_finish_power_on(struct if_sdio_card *card) sdio_release_host(func); - /* -* FUNC_INIT is required for SD8688 WLAN/BT multiple functions

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-20 Thread Bing Zhao
Hi Lubomir, > > > @@ -825,20 +825,6 @@ static void if_sdio_finish_power_on(struct > > > if_sdio_card *card) > > > > > > sdio_release_host(func); > > > > > > - /* > > > - * FUNC_INIT is required for SD8688 WLAN/BT multiple functions > > > - */ > > > - if (card->model == MODEL_8688) { > > > -

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-20 Thread Bing Zhao
Hi Lubomir, @@ -825,20 +825,6 @@ static void if_sdio_finish_power_on(struct if_sdio_card *card) sdio_release_host(func); - /* - * FUNC_INIT is required for SD8688 WLAN/BT multiple functions - */ - if (card-model == MODEL_8688) { - struct cmd_header cmd;

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-18 Thread Lubomir Rintel
On Fri, 2013-01-18 at 12:28 -0800, Bing Zhao wrote: > Hi Lubomir, > > > It actually times out on a 8688 present in GuruPlug with sd8688.bin > > (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in > > linux-firmware tree), but the adapter works fine. > > > > For that firmware times

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-02-18 Thread Lubomir Rintel
On Fri, 2013-01-18 at 12:28 -0800, Bing Zhao wrote: Hi Lubomir, It actually times out on a 8688 present in GuruPlug with sd8688.bin (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in linux-firmware tree), but the adapter works fine. For that firmware times out with

Re: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-01-30 Thread John W. Linville
On Fri, Jan 18, 2013 at 12:28:17PM -0800, Bing Zhao wrote: > Hi Lubomir, > > > It actually times out on a 8688 present in GuruPlug with sd8688.bin > > (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in > > linux-firmware tree), but the adapter works fine. > > > > For that

Re: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-01-30 Thread John W. Linville
On Fri, Jan 18, 2013 at 12:28:17PM -0800, Bing Zhao wrote: Hi Lubomir, It actually times out on a 8688 present in GuruPlug with sd8688.bin (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in linux-firmware tree), but the adapter works fine. For that firmware times out

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-01-18 Thread Bing Zhao
Hi Lubomir, > It actually times out on a 8688 present in GuruPlug with sd8688.bin > (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in > linux-firmware tree), but the adapter works fine. > > For that firmware times out with libertas_uap [1] as well, though it succeeds > with

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

2013-01-18 Thread Bing Zhao
Hi Lubomir, It actually times out on a 8688 present in GuruPlug with sd8688.bin (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in linux-firmware tree), but the adapter works fine. For that firmware times out with libertas_uap [1] as well, though it succeeds with