Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-07 Thread David Rientjes
On Mon, 7 Jan 2013, Andrew Morton wrote: > --- > a/mm/compaction.c~mm-compaction-fix-echo-1-compact_memory-return-error-issue-fix > +++ a/mm/compaction.c > @@ -1150,7 +1150,7 @@ unsigned long try_to_compact_pages(struc > > > /* Compact all zones within a node */ > -static int __compact_pgdat

Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-07 Thread David Rientjes
On Sun, 6 Jan 2013, Jason Liu wrote: > when run the folloing command under shell, it will return error > sh/$ echo 1 > /proc/sys/vm/compact_memory > sh/$ sh: write error: Bad address > > After strace, I found the following log: > ... > write(1, "1\n", 2) = 3 > write(1, "", 429496729

Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-07 Thread Andrew Morton
On Mon, 7 Jan 2013 13:57:21 + Mel Gorman wrote: > On Sun, Jan 06, 2013 at 03:44:33PM +0800, Jason Liu wrote: > > when run the folloing command under shell, it will return error > > sh/$ echo 1 > /proc/sys/vm/compact_memory > > sh/$ sh: write error: Bad address > > > > After strace, I found t

Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-07 Thread Mel Gorman
On Sun, Jan 06, 2013 at 03:44:33PM +0800, Jason Liu wrote: > when run the folloing command under shell, it will return error > sh/$ echo 1 > /proc/sys/vm/compact_memory > sh/$ sh: write error: Bad address > > After strace, I found the following log: > ... > write(1, "1\n", 2) = 3 > w

Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-06 Thread Michal Nazarewicz
On Sun, Jan 06 2013, Simon Jeons wrote: >> >write(1, "1\n", 2) = 3 >> Here it tells it. > On Sun, 2013-01-06 at 08:48 +, Liu Hui-R64343 wrote: > Why this value trouble you? Because write() is supposed to return the number of bytes successfully written. -- Best regard

RE: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-06 Thread Liu Hui-R64343
hir...@jp.fujitsu.com; linux...@kvack.org >Subject: Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return >error issue > >On Sun, 2013-01-06 at 08:48 +, Liu Hui-R64343 wrote: >> >-Original Message- >> >From: Wanpeng Li [mailto:liw...@linux.vn

Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-06 Thread Simon Jeons
pm@linux- > >foundation.org; r...@redhat.com; minc...@kernel.org; > >kamezawa.hir...@jp.fujitsu.com; linux...@kvack.org > >Subject: Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return > >error issue > > > >On Sun, Jan 06, 2013 at 08:11:58AM +, Liu Hu

RE: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-06 Thread Liu Hui-R64343
jp.fujitsu.com; linux...@kvack.org >Subject: Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return >error issue > >On Sun, Jan 06, 2013 at 08:11:58AM +, Liu Hui-R64343 wrote: >>>-Original Message- >>>From: Wanpeng Li [mailto:liw...@linux.vnet.ib

RE: [PATCH] mm: compaction: fix echo 1 > compact_memory return error issue

2013-01-06 Thread Liu Hui-R64343
jp.fujitsu.com; linux...@kvack.org >Subject: Re: [PATCH] mm: compaction: fix echo 1 > compact_memory return >error issue > >On Sun, Jan 06, 2013 at 03:44:33PM +0800, Jason Liu wrote: > >Hi Jason, > >>when run the folloing command under shell, it will return error sh/$ &g