RE: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-12 Thread Christian Borntraeger
On 12.04.21 12:53, Muchun Song wrote: On Mon, Apr 12, 2021 at 6:42 PM Christian Borntraeger wrote: FWIW, I was away the last week, and I checked yesterdays next (e99d8a849517) regression runs. I still do see errors in our CI system: [ 2263.021681] [ cut here ] [ 22

Re: [External] Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-12 Thread Muchun Song
On Mon, Apr 12, 2021 at 6:42 PM Christian Borntraeger wrote: > > FWIW, I was away the last week, and I checked yesterdays next (e99d8a849517) > regression runs. > I still do see errors in our CI system: > > [ 2263.021681] [ cut here ] > [ 2263.021697] percpu ref (obj_cgrou

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-12 Thread Christian Borntraeger
FWIW, I was away the last week, and I checked yesterdays next (e99d8a849517) regression runs. I still do see errors in our CI system: [ 2263.021681] [ cut here ] [ 2263.021697] percpu ref (obj_cgroup_release) <= 0 (0) after switching to atomic [ 2263.021748] WARNING: CPU

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-02 Thread Roman Gushchin
On Fri, Apr 02, 2021 at 06:04:54PM -0700, Andrew Morton wrote: > On Wed, 31 Mar 2021 20:35:02 -0700 Roman Gushchin wrote: > > > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: > > > On 2021/4/1 11:01, Muchun Song wrote: > > > > Christian Borntraeger reported a warning about "percpu re

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-02 Thread Shakeel Butt
On Fri, Apr 2, 2021 at 6:04 PM Andrew Morton wrote: > > On Wed, 31 Mar 2021 20:35:02 -0700 Roman Gushchin wrote: > > > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: > > > On 2021/4/1 11:01, Muchun Song wrote: > > > > Christian Borntraeger reported a warning about "percpu ref > > > >

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-04-02 Thread Andrew Morton
On Wed, 31 Mar 2021 20:35:02 -0700 Roman Gushchin wrote: > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: > > On 2021/4/1 11:01, Muchun Song wrote: > > > Christian Borntraeger reported a warning about "percpu ref > > > (obj_cgroup_release) <= 0 (-1) after switching to atomic". > > >

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-03-31 Thread Miaohe Lin
On 2021/4/1 11:35, Roman Gushchin wrote: > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: >> On 2021/4/1 11:01, Muchun Song wrote: >>> Christian Borntraeger reported a warning about "percpu ref >>> (obj_cgroup_release) <= 0 (-1) after switching to atomic". >>> Because we forgot to obta

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-03-31 Thread Roman Gushchin
On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: > On 2021/4/1 11:01, Muchun Song wrote: > > Christian Borntraeger reported a warning about "percpu ref > > (obj_cgroup_release) <= 0 (-1) after switching to atomic". > > Because we forgot to obtain the reference to the objcg and > > wrongl

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-03-31 Thread Miaohe Lin
On 2021/4/1 11:01, Muchun Song wrote: > Christian Borntraeger reported a warning about "percpu ref > (obj_cgroup_release) <= 0 (-1) after switching to atomic". > Because we forgot to obtain the reference to the objcg and > wrongly obtain the reference of memcg. > > Reported-by: Christian Borntraeg

Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

2021-03-31 Thread Shakeel Butt
On Wed, Mar 31, 2021 at 8:02 PM Muchun Song wrote: > > Christian Borntraeger reported a warning about "percpu ref > (obj_cgroup_release) <= 0 (-1) after switching to atomic". > Because we forgot to obtain the reference to the objcg and > wrongly obtain the reference of memcg. > > Reported-by: Chri