Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2008-01-07 Thread Eric W. Biederman
"Peer Chen" <[EMAIL PROTECTED]> writes: > Eric, > Any decision for this patch, if not, currently we prefer to add all our > code to quirks.c. Sorry. I think adding the code to quirks.c is fine. For bisection and code inspection purposes I would prefer the code to come as a patchset of two patch

RE: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2008-01-06 Thread Peer Chen
linux-kernel; akpm; Andy Currid Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability "Peer Chen" <[EMAIL PROTECTED]> writes: > I feel it's dangerous to set the En bit on Intel platform, If the HT MSI > En is set, the MSI should be expected to transf

RE: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2008-01-02 Thread Peer Chen
: set 'En' bit of MSI Mapping Capability "Peer Chen" <[EMAIL PROTECTED]> writes: > I feel it's dangerous to set the En bit on Intel platform, If the HT MSI > En is set, the MSI should be expected to transform to HT INT message > format. It may cause inte

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-24 Thread Eric W. Biederman
"Peer Chen" <[EMAIL PROTECTED]> writes: > I feel it's dangerous to set the En bit on Intel platform, If the HT MSI > En is set, the MSI should be expected to transform to HT INT message > format. It may cause interrupt lost or hardware internal state machine > failed depend on the hardware design.

RE: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-24 Thread Peer Chen
From: Eric W. Biederman [mailto:[EMAIL PROTECTED] Sent: Friday, December 21, 2007 6:48 AM To: Peer Chen Cc: peerchen; linux-kernel; akpm; Andy Currid Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability "Peer Chen" <[EMAIL PROTECTED]> writes: > The q

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-20 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > On Wed, 19 Dec 2007 16:41:25 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > >> It would be better to just add a stub implementation of >> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp >> tricks. > > > And by this I really

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-20 Thread Eric W. Biederman
"Peer Chen" <[EMAIL PROTECTED]> writes: > The quirk is for our Intel platform, we don't want HT MSI mapping > enabled in any of our devices. Why is this a problem? I seem to recall a real hypertransport bus downstream of the Intel cpu. If there is a real hypertransport bus in the middle then wh

RE: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-20 Thread Peer Chen
Chen Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability "peerchen" <[EMAIL PROTECTED]> writes: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. > Set the 'En' bit when setup pci and add the

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-19 Thread Andrew Morton
On Wed, 19 Dec 2007 16:41:25 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > It would be better to just add a stub implementation of > ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp > tricks. And by this I really do mean going into each include/asm-*/pci.h and adding

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-19 Thread Andrew Morton
On Tue, 18 Dec 2007 23:00:52 +0800 "peerchen" <[EMAIL PROTECTED]> wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. > Set the 'En' bit when setup pci and add the quirk for some nvidia devices. > > The patch base on kernel 2.6.24-rc5 > > Signed-off-by:

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-18 Thread Eric W. Biederman
"peerchen" <[EMAIL PROTECTED]> writes: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. > Set the 'En' bit when setup pci and add the quirk for some nvidia devices. > > The patch base on kernel 2.6.24-rc5 Ok. This is starting to look good. > Signed-off-by: