Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

On Wed, Oct 08, 2014 at 08:54:58AM +, David Laight wrote: > Hmmm... in that case you may not want the compiler to convert the bit value > to a 'bool' at all. > > Passing 'id_entry->driver_data' through (that doesn't look like a field name > for > 'quirk flags) would generate better code. > >

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi, David Laight wrote: > From: Lothar Waßmann > > David Laight wrote: > > > From: Eric Dumazet > > > > On Tue, 2014-10-07 at 15:19 +0200, Lothar Wamann wrote: > > > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > > > > performance") > > > > > introduced a regression

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Sergei Shtylyov > On 10/07/2014 05:19 PM, Lothar Wamann wrote: > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > performance") > > introduced a regression for i.MX28. The swap_buffer() function doing > > the endian conversion of the received data on i.MX28 may a

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Lothar Waßmann > David Laight wrote: > > From: Eric Dumazet > > > On Tue, 2014-10-07 at 15:19 +0200, Lothar Wamann wrote: > > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > > > performance") > > > > introduced a regression for i.MX28. The swap_buffer() function

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi, David Laight wrote: > From: Eric Dumazet > > On Tue, 2014-10-07 at 15:19 +0200, Lothar Wamann wrote: > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > > performance") > > > introduced a regression for i.MX28. The swap_buffer() function doing > > > the endian conve

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi, David Laight wrote: > From: Lothar > > David Laight wrote: > > > From: Lothar Waßmann > > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > > > performance") > > > > introduced a regression for i.MX28. The swap_buffer() function doing > > > > the endian conversion o

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi, David Miller wrote: > From: Lothar Waßmann > Date: Tue, 7 Oct 2014 15:19:37 +0200 > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > performance") > > introduced a regression for i.MX28. The swap_buffer() function doing > > the endian conversion of the received

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Lothar Waßmann Date: Tue, 7 Oct 2014 15:19:37 +0200 > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > performance") > introduced a regression for i.MX28. The swap_buffer() function doing > the endian conversion of the received data on i.MX28 may access memory > beyo

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hello. On 10/07/2014 05:19 PM, Lothar Waßmann wrote: commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx performance") introduced a regression for i.MX28. The swap_buffer() function doing the endian conversion of the received data on i.MX28 may access memory beyond the actual

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Eric Dumazet > On Tue, 2014-10-07 at 15:19 +0200, Lothar Wamann wrote: > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > performance") > > introduced a regression for i.MX28. The swap_buffer() function doing > > the endian conversion of the received data on i.MX28

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

On Tue, 2014-10-07 at 14:23 +, David Laight wrote: > The point I was making is that if you have to do a read-write of the received > data (to byteswap it) then you might as well always copy it into a new skb > that > is just big enough for the actual receive frame. +1 -- To unsubscribe fro

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

On Tue, 2014-10-07 at 15:19 +0200, Lothar Waßmann wrote: > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > performance") > introduced a regression for i.MX28. The swap_buffer() function doing > the endian conversion of the received data on i.MX28 may access memory > beyond t

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Lothar > David Laight wrote: > > From: Lothar Waßmann > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > > performance") > > > introduced a regression for i.MX28. The swap_buffer() function doing > > > the endian conversion of the received data on i.MX28 may acces

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi, David Laight wrote: > From: Lothar Waßmann > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > > performance") > > introduced a regression for i.MX28. The swap_buffer() function doing > > the endian conversion of the received data on i.MX28 may access memory > > beyond

Re: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

Hi Lothar, On Tue, Oct 7, 2014 at 10:19 AM, Lothar Waßmann wrote: > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > performance") > introduced a regression for i.MX28. The swap_buffer() function doing > the endian conversion of the received data on i.MX28 may access memor

RE: [PATCH] net: fec: fix regression on i.MX28 introduced by rx_copybreak support

From: Lothar Waßmann > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx > performance") > introduced a regression for i.MX28. The swap_buffer() function doing > the endian conversion of the received data on i.MX28 may access memory > beyond the actual packet size in the DMA buf