Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-09 Thread Peter Zijlstra
On Mon, May 11, 2015 at 12:00:30PM +0200, Ingo Molnar wrote: > > I'm for the clean revert I think. Crashing is bad, but hiding/delaying > > it seems counter productive too, it'll just mean we'll only learn about > > it later. > > So should I revert c05199e5a57a, with a Cc: stable? Yep. -- To

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-09 Thread Ingo Molnar
* Vince Weaver wrote: > On Mon, 11 May 2015, Ingo Molnar wrote: > > > > > * Peter Zijlstra wrote: > > > > > On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: > > > > > > > > > > > > > > > This leads me to believe that this patch: > > > > > > > > > > > > commit

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-09 Thread Peter Zijlstra
On Mon, May 11, 2015 at 12:00:30PM +0200, Ingo Molnar wrote: I'm for the clean revert I think. Crashing is bad, but hiding/delaying it seems counter productive too, it'll just mean we'll only learn about it later. So should I revert c05199e5a57a, with a Cc: stable? Yep. -- To unsubscribe

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-09 Thread Ingo Molnar
* Vince Weaver vincent.wea...@maine.edu wrote: On Mon, 11 May 2015, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: This leads me to believe that this patch: commit

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-08 Thread Vince Weaver
On Mon, 11 May 2015, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: > > > > > > > > > > > > This leads me to believe that this patch: > > > > > > > > > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > > > > > Author: Kan

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-06-08 Thread Vince Weaver
On Mon, 11 May 2015, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-05-11 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: > > > > > > > > > This leads me to believe that this patch: > > > > > > > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > > > > Author: Kan Liang > > > > Date: Tue Jan 20 04:54:25 2015 + > > > > >

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-05-11 Thread Ingo Molnar
* Peter Zijlstra pet...@infradead.org wrote: On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-28 Thread Peter Zijlstra
On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: > > > > > > This leads me to believe that this patch: > > > > > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > > > Author: Kan Liang > > > Date: Tue Jan 20 04:54:25 2015 + > > > > > > perf/x86/intel/uncore: Move

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-28 Thread Stephane Eranian
On Sun, Apr 26, 2015 at 8:43 PM, Liang, Kan wrote: > >> >> > This leads me to believe that this patch: >> > >> > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc >> > Author: Kan Liang >> > Date: Tue Jan 20 04:54:25 2015 + >> > >> > perf/x86/intel/uncore: Move uncore_box_init() out of

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-28 Thread Peter Zijlstra
On Mon, Apr 27, 2015 at 03:43:32AM +, Liang, Kan wrote: This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015 + perf/x86/intel/uncore: Move

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-28 Thread Stephane Eranian
On Sun, Apr 26, 2015 at 8:43 PM, Liang, Kan kan.li...@intel.com wrote: This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015 + perf/x86/intel/uncore: Move

RE: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-26 Thread Liang, Kan
> > > This leads me to believe that this patch: > > > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > > Author: Kan Liang > > Date: Tue Jan 20 04:54:25 2015 + > > > > perf/x86/intel/uncore: Move uncore_box_init() out of driver > initialization > > > > If I revert it, I bet things

RE: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-26 Thread Liang, Kan
This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015 + perf/x86/intel/uncore: Move uncore_box_init() out of driver initialization If I revert it, I bet things

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Andi Kleen
> This leads me to believe that this patch: > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > Author: Kan Liang > Date: Tue Jan 20 04:54:25 2015 + > > perf/x86/intel/uncore: Move uncore_box_init() out of driver initialization > > If I revert it, I bet things will work again. Yes

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Stephane Eranian
On Fri, Apr 24, 2015 at 12:22 PM, Bjorn Helgaas wrote: > On Fri, Apr 24, 2015 at 9:38 AM, Stephane Eranian wrote: >> On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver >> wrote: >>> On Fri, 24 Apr 2015, Vince Weaver wrote: >>> [ 79.473121] kernel BUG at mm/vmalloc.c:1335! [ 79.477705]

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Bjorn Helgaas
On Fri, Apr 24, 2015 at 9:38 AM, Stephane Eranian wrote: > On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver > wrote: >> On Fri, 24 Apr 2015, Vince Weaver wrote: >> >>> [ 79.473121] kernel BUG at mm/vmalloc.c:1335! >>> [ 79.477705] invalid opcode: [#1] SMP >> ... >>> [ 79.694391] Call

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Stephane Eranian
On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver wrote: > On Fri, 24 Apr 2015, Vince Weaver wrote: > >> [ 79.473121] kernel BUG at mm/vmalloc.c:1335! >> [ 79.477705] invalid opcode: [#1] SMP > ... >> [ 79.694391] Call Trace: >> [ 79.696997] >> [ 79.699090] []

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Vince Weaver
On Fri, 24 Apr 2015, Vince Weaver wrote: > [ 79.473121] kernel BUG at mm/vmalloc.c:1335! > [ 79.477705] invalid opcode: [#1] SMP ... > [ 79.694391] Call Trace: > [ 79.696997] > [ 79.699090] [] get_vm_area_caller+0x40/0x50 > [ 79.705505] [] ?

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Vince Weaver
On Thu, 23 Apr 2015, Stephane Eranian wrote: > This patch fixes a bug introduced by: > > commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc > Author: Kan Liang > Date: Tue Jan 20 04:54:25 2015 + I was hoping this would fix the uncore/imc bug that the perf_fuzzer triggers on my Haswell box,

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Vince Weaver
On Thu, 23 Apr 2015, Stephane Eranian wrote: This patch fixes a bug introduced by: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015 + I was hoping this would fix the uncore/imc bug that the perf_fuzzer triggers on

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Vince Weaver
On Fri, 24 Apr 2015, Vince Weaver wrote: [ 79.473121] kernel BUG at mm/vmalloc.c:1335! [ 79.477705] invalid opcode: [#1] SMP ... [ 79.694391] Call Trace: [ 79.696997] IRQ [ 79.699090] [811b2130] get_vm_area_caller+0x40/0x50 [ 79.705505] [81039f4d] ?

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Stephane Eranian
On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver vincent.wea...@maine.edu wrote: On Fri, 24 Apr 2015, Vince Weaver wrote: [ 79.473121] kernel BUG at mm/vmalloc.c:1335! [ 79.477705] invalid opcode: [#1] SMP ... [ 79.694391] Call Trace: [ 79.696997] IRQ [ 79.699090]

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Andi Kleen
This leads me to believe that this patch: commit c05199e5a57a579fea1e8fa65e2b511ceb524ffc Author: Kan Liang kan.li...@intel.com Date: Tue Jan 20 04:54:25 2015 + perf/x86/intel/uncore: Move uncore_box_init() out of driver initialization If I revert it, I bet things will work

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Bjorn Helgaas
On Fri, Apr 24, 2015 at 9:38 AM, Stephane Eranian eran...@google.com wrote: On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver vincent.wea...@maine.edu wrote: On Fri, 24 Apr 2015, Vince Weaver wrote: [ 79.473121] kernel BUG at mm/vmalloc.c:1335! [ 79.477705] invalid opcode: [#1] SMP

Re: [PATCH] perf/x86/intel/uncore: fix IMC missing box initialization

2015-04-24 Thread Stephane Eranian
On Fri, Apr 24, 2015 at 12:22 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Apr 24, 2015 at 9:38 AM, Stephane Eranian eran...@google.com wrote: On Fri, Apr 24, 2015 at 7:03 AM, Vince Weaver vincent.wea...@maine.edu wrote: On Fri, 24 Apr 2015, Vince Weaver wrote: [ 79.473121] kernel