Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-06-03 Thread Linus Walleij
On Sat, May 30, 2020 at 10:49 PM Christophe JAILLET wrote: > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' can be re

Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-06-02 Thread Christophe JAILLET
Le 02/06/2020 à 12:13, Dan Carpenter a écrit : On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote: 'pinctrl_unregister()' should not be called to undo 'devm_pinctrl_register_and_init()', it is already handled by the framework. This simplifies the error handling paths of the prob

Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-06-02 Thread Dan Carpenter
On Sat, May 30, 2020 at 10:49:55PM +0200, Christophe JAILLET wrote: > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' c

RE: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'

2020-06-01 Thread Aisheng Dong
> From: Christophe JAILLET > Sent: Sunday, May 31, 2020 4:50 AM > > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' c