Re: [PATCH] radix-tree: Fix private list warnings

2017-01-18 Thread Johannes Weiner
On Sat, Jan 14, 2017 at 07:57:51PM -0500, Johannes Weiner wrote: > On Sat, Jan 14, 2017 at 09:31:51PM +, Matthew Wilcox wrote: > > From: Johannes Weiner [mailto:han...@cmpxchg.org] > > > On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote: > > > > The newly introduced warning in radi

Re: [PATCH] radix-tree: Fix private list warnings

2017-01-14 Thread Johannes Weiner
On Sat, Jan 14, 2017 at 09:31:51PM +, Matthew Wilcox wrote: > From: Johannes Weiner [mailto:han...@cmpxchg.org] > > On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote: > > > The newly introduced warning in radix_tree_free_nodes() was testing the > > > wrong variable; it should have

RE: [PATCH] radix-tree: Fix private list warnings

2017-01-14 Thread Matthew Wilcox
From: Johannes Weiner [mailto:han...@cmpxchg.org] > On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote: > > The newly introduced warning in radix_tree_free_nodes() was testing the > > wrong variable; it should have been 'old' instead of 'node'. Rather > > than replace that one instance

Re: [PATCH] radix-tree: Fix private list warnings

2017-01-14 Thread Johannes Weiner
On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The newly introduced warning in radix_tree_free_nodes() was testing the > wrong variable; it should have been 'old' instead of 'node'. Rather > than replace that one instance, I noticed that we can simply