RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-06-10 Thread Yang, Fei
> > >Why is this being added to the regmap core rather than being > > >implemented in using the reg_write() and reg_read() callbacks in the > > >core driver for the PMIC? > > Thanks. I don't receive this message before in eamil. > > Current regmap only support register access using several bus:

RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-20 Thread Yang, Fei
>> The detail is >> Beside pmic core driver itself, there are many pmic function device >> dirvers, such as gpio, theremal, charger, bcu ..., will use this regmap api >> to access registers. > This sounds like this is a single device, not a generic bus. Well, yes this is more like a bridge to th

Re: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-20 Thread Mark Brown
On Wed, May 20, 2015 at 01:02:49AM +, Zha, Qipeng wrote: Please don't top post. > Not sure what's your mean using regmap api without bus suport for this case > Confirm many device driver will use this api. Please take a look at the code, particularly the reg_read() and reg_write() interface

RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-19 Thread Zha, Qipeng
sub device drivers. Best wishes Qipeng -Original Message- From: Mark Brown [mailto:broo...@kernel.org] Sent: Tuesday, May 19, 2015 8:09 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PM

Re: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-19 Thread Mark Brown
On Tue, May 19, 2015 at 04:57:00AM +, Zha, Qipeng wrote: > >Why is this being added to the regmap core rather than being implemented > >in using the reg_write() and reg_read() callbacks in the core driver for > >the PMIC? > Thanks. I don't receive this message before in eamil. > Current regma

RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-18 Thread Zha, Qipeng
Sent: Monday, May 18, 2015 7:21 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support On Mon, May 18, 2015 at 08:10:04AM +, Zha, Qipeng wrote: > Hi Broonie > > Can y

Re: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-18 Thread Mark Brown
On Mon, May 18, 2015 at 08:10:04AM +, Zha, Qipeng wrote: > Hi Broonie > > Can you help comment on this patch ? > We do really want to leverage current regmap framework to acess intel pmic > devices. > So please evaluate this driver, thanks. Please don't send contentless pings, and please ref

RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-18 Thread Zha, Qipeng
Hi Broonie Can you help comment on this patch ? We do really want to leverage current regmap framework to acess intel pmic devices. So please evaluate this driver, thanks. Best wishes Qipeng -Original Message- From: Zha, Qipeng Sent: Tuesday, April 21, 2015 7:39 AM To: linux-kernel@

Re: [PATCH] regmap: add virtual PMIC IPC bus support

2015-04-20 Thread Mark Brown
On Tue, Apr 21, 2015 at 07:38:58AM +0800, qipeng.zha wrote: > From: "qipeng.zha" > > There defined Whiskey Cove PMIC controller on one Intel platform, > and all registers on this PMIC are accessed by IPC commands. > This patch is to utilize regmap framework to access PMIC registers > for PMIC cor