RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-12 Thread Vitor Soares
Hi Eugeniy, From: Eugeniy Paltsev Date: Fri, Apr 12, 2019 at 14:22:33 > Hi Vitor, > > On Mon, 2019-04-08 at 13:25 +, Vitor Soares wrote: > > Hi Eugeniy, > > > > From: Eugeniy Paltsev > > Date: Mon, Apr 08, 2019 at 12:40:00 > > > > > Hi Vitor, > > > > > > On Mon, 2019-04-08 at 12:31 +020

Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-12 Thread Eugeniy Paltsev
Hi Jose, On Mon, 2019-04-08 at 11:23 +, Jose Abreu wrote: > From: Vitor Soares > Date: Mon, Apr 08, 2019 at 11:31:23 > > > static const struct reset_control_ops axs10x_reset_ops = { > > - .reset = axs10x_reset_reset, > > Eugeniy, Alexey, > > I think the implementation of this callback

Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-12 Thread Eugeniy Paltsev
Hi Vitor, On Mon, 2019-04-08 at 13:25 +, Vitor Soares wrote: > Hi Eugeniy, > > From: Eugeniy Paltsev > Date: Mon, Apr 08, 2019 at 12:40:00 > > > Hi Vitor, > > > > On Mon, 2019-04-08 at 12:31 +0200, Vitor Soares wrote: > > > Some custom IP-block connected to ARC AXS10x board need assert and

RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Vitor Soares
Hi Eugeniy, From: Eugeniy Paltsev Date: Mon, Apr 08, 2019 at 12:40:00 > Hi Vitor, > > On Mon, 2019-04-08 at 12:31 +0200, Vitor Soares wrote: > > Some custom IP-block connected to ARC AXS10x board need assert and > > deassert functions to control reset signal of selected peripherals. > > > > Th

Re: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Eugeniy Paltsev
Hi Vitor, On Mon, 2019-04-08 at 12:31 +0200, Vitor Soares wrote: > Some custom IP-block connected to ARC AXS10x board need assert and > deassert functions to control reset signal of selected peripherals. > > This patch improve AXS10x reset driver by adding assert and deassert > callbacks. In th

RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Jose Abreu
From: Vitor Soares Date: Mon, Apr 08, 2019 at 11:31:23 > static const struct reset_control_ops axs10x_reset_ops = { > - .reset = axs10x_reset_reset, Eugeniy, Alexey, I think the implementation of this callback is wrong: you should readl_poll_timeout_atomic() until the reset bit is not cle