RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
On Thursday, April 03, 2014 10:56 AM, Dan Carpenter wrote: > > Signed-off-by is like signing a legal document, to show you haven't violated > copyright law or anything while the patch was in your hands. > You should use Acked-by or Reviewed-by depending on what you mean. > Dan, Thank you for

Re: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 05:14:44PM +, Insop Song wrote: > Added signed-off-by below: > Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean.

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
Added signed-off-by below: On Thursday, April 03, 2014 1:32 AM, Paul Bolle wrote: > > This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig > macro to do so. Since no code appears to even care about the DEBUG macro > this line can safely be removed. > > Signed-off-by: Paul

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
Added signed-off-by below: On Thursday, April 03, 2014 1:32 AM, Paul Bolle wrote: This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig macro to do so. Since no code appears to even care about the DEBUG macro this line can safely be removed. Signed-off-by: Paul Bolle

Re: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Dan Carpenter
On Thu, Apr 03, 2014 at 05:14:44PM +, Insop Song wrote: Added signed-off-by below: Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean.

RE: [PATCH] staging: fpgaboot: clean up Makefile

2014-04-03 Thread Insop Song
On Thursday, April 03, 2014 10:56 AM, Dan Carpenter wrote: Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean. Dan, Thank you for