RE: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Anson Huang
ubject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq > > While I am aligned with the fact that we need to carry this code for backward > compatibility, there are few things I would suggest to improve. > > On Wed, Oct 24, 2018 at 12:10 PM Anson Huang > wr

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Viresh Kumar
While I am aligned with the fact that we need to carry this code for backward compatibility, there are few things I would suggest to improve. On Wed, Oct 24, 2018 at 12:10 PM Anson Huang wrote: > static int imx_thermal_probe(struct platform_device *pdev) > { > @@ -743,6 +745,7 @@ static int imx

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Lucas Stach
l.lezc...@linaro.org] > > > Sent: 2018年11月20日 16:54 > > > To: Anson Huang ; rui.zh...@intel.com; > > > edubez...@gmail.com; linux...@vger.kernel.org; > > > linux-kernel@vger.kernel.org > > > Cc: dl-linux-imx > > > Subject: Re: [PATCH] thermal: im

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
edubez...@gmail.com; linux...@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: dl-linux-imx >> Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq >> >> On 20/11/2018 09:47, Anson Huang wrote: >>> Hi, Daniel >>> &g

RE: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Anson Huang
> Cc: dl-linux-imx > Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq > > On 20/11/2018 09:47, Anson Huang wrote: > > Hi, Daniel > > > > Best Regards! > > Anson Huang > > > >> -Original Message- > >> From: Daniel L

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
edubez...@gmail.com; linux...@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: dl-linux-imx >> Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq >> >> On 24/10/2018 08:39, Anson Huang wrote: >>> The thermal driver is a standalone driver

RE: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Anson Huang
> Cc: dl-linux-imx > Subject: Re: [PATCH] thermal: imx: fix for dependency on cpu-freq > > On 24/10/2018 08:39, Anson Huang wrote: > > The thermal driver is a standalone driver for monitoring SoC > > temperature by enabling thermal sensor, so it can be enabled even when >

Re: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-20 Thread Daniel Lezcano
On 24/10/2018 08:39, Anson Huang wrote: > The thermal driver is a standalone driver for monitoring SoC temperature > by enabling thermal sensor, so it can be enabled even when CONFIG_CPU_FREQ > is NOT set. So remove the dependency with CPU_THERMAL. > > Add CONFIG_CPU_FREQ check for cpu-freq relate

RE: [PATCH] thermal: imx: fix for dependency on cpu-freq

2018-11-19 Thread Anson Huang
Gentle Ping... Best Regards! Anson Huang > -Original Message- > From: Anson Huang > Sent: 2018年10月24日 14:40 > To: rui.zh...@intel.com; edubez...@gmail.com; linux...@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx > Subject: [PATCH] thermal: imx: fix for dependency on c