Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-07 Thread Jarkko Sakkinen
syskin, Alexander > > ; linux-integr...@vger.kernel.org; linux- > > security-mod...@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm > > > > On Wed, Jun 06, 2018 at 11:01:42AM +, Winkler, Tom

RE: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-07 Thread Winkler, Tomas
nel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm > > On Wed, Jun 06, 2018 at 11:01:42AM +, Winkler, Tomas wrote: > > > > > > On Wed, May 30, 2018 at 10:52:28AM +, Winkler, Tomas wrote: > > > > &

Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-07 Thread Jarkko Sakkinen
On Wed, Jun 06, 2018 at 11:01:42AM +, Winkler, Tomas wrote: > > > > On Wed, May 30, 2018 at 10:52:28AM +, Winkler, Tomas wrote: > > > > > > > > On Wed, May 23, 2018 at 01:48:17PM +, Winkler, Tomas wrote: > > > > > > > > > > > On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wro

RE: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-06 Thread Winkler, Tomas
> > On Wed, May 30, 2018 at 10:52:28AM +, Winkler, Tomas wrote: > > > > > > On Wed, May 23, 2018 at 01:48:17PM +, Winkler, Tomas wrote: > > > > > > > > > On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > > > > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, To

Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-30 Thread Jarkko Sakkinen
On Wed, May 30, 2018 at 10:52:28AM +, Winkler, Tomas wrote: > > > > On Wed, May 23, 2018 at 01:48:17PM +, Winkler, Tomas wrote: > > > > > > > On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrot

RE: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-30 Thread Winkler, Tomas
> > On Wed, May 23, 2018 at 01:48:17PM +, Winkler, Tomas wrote: > > > > > On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > > > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() > >

Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-30 Thread Jarkko Sakkinen
On Wed, May 23, 2018 at 01:48:17PM +, Winkler, Tomas wrote: > > > On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() > > wrappers > > >

RE: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-23 Thread Winkler, Tomas
> On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() > wrappers > > > > to streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED flag > is > >

Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-23 Thread Jarkko Sakkinen
On Tue, May 22, 2018 at 09:27:46AM +, Winkler, Tomas wrote: > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() wrappers to > > > streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED flag is > > abused > > > t

RE: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-22 Thread Winkler, Tomas
> > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() wrappers to > > streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED flag is > abused > > to resolve tpm spaces recursive calls to tpm_transmit(). > > This looks good

Re: [PATCH] tpm: separate cmd_ready/go_idle from runtime_pm

2018-05-22 Thread Jarkko Sakkinen
On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler wrote: > New wrappers are added tpm_cmd_ready() and tpm_go_idle() wrappers to > streamline tpm_try_transmit code. TPM_TRANSMIT_UNLOCKED flag is abused to > resolve tpm spaces recursive calls to tpm_transmit(). This looks good and all but I do