RE: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-17 Thread Peter Chen
> On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote: > > > > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > > > Well prior to your code, there was already a possibility for both > > > > ci->phy and ci->usb_phy to be valid. I don't think it's really > > > > ci->useful > > > >

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-17 Thread Paul Kocialkowski
Hi, On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote: > > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > > Well prior to your code, there was already a possibility for both > > > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > > > to avoid the

RE: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-16 Thread Peter Chen
> > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > > Well prior to your code, there was already a possibility for both > > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > > to avoid the fallback when a generic PHY has already been found, it's > > confusing.

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-16 Thread Paul Kocialkowski
Hi, On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote: > Well prior to your code, there was already a possibility for both > ci->phy and ci->usb_phy to be valid. I don't think it's really useful > to avoid the fallback when a generic PHY has already been found, it's > confusing. If really

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-16 Thread Thomas Petazzoni
Hello, On Wed, 16 Jan 2019 14:30:28 +0100, Paul Kocialkowski wrote: > > Why is this conditional on the generic PHY lookup failing? > > > > Don't we simply want: > > > > ci->phy = devm_phy_get(dev->parent, "usb-phy"); > > ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys",

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-16 Thread Paul Kocialkowski
Hi, On Wed, 2019-01-16 at 11:53 +0100, Thomas Petazzoni wrote: > Hello, > > Thanks for the patch! And thanks for the review! > On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote: > > According to the chipidea driver bindings, the USB PHY is specified via > > the "phys" phandle node.

Re: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-01-16 Thread Thomas Petazzoni
Hello, Thanks for the patch! On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote: > According to the chipidea driver bindings, the USB PHY is specified via > the "phys" phandle node. However, this only takes effect for USB PHYs > that use the common PHY framework. For legacy USB PHYs, a